Skip to content

Conversation

@larryhastings
Copy link
Contributor

@larryhastings larryhastings commented Sep 14, 2018

Published as a PR just to give people the Github review interface. See bpo-34690.

https://bugs.python.org/issue34690

@larryhastings larryhastings requested a review from a team September 14, 2018 21:25
@larryhastings larryhastings changed the title DO NOT MERGE - Experimental "frozen modules". bpo-34690: DO NOT MERGE - Experimental "frozen modules". Sep 14, 2018
@gvanrossum
Copy link
Member

Where's the code to generate frozenmodules.c?

I'd prefer the generated tables to be separated from the interesting (hand-written) code in frozenmodules.c -- GitHub flat-out refuses to display it, which makes reviewing the hand-written code there impossible.

PS. IIRC making this possible is the reason we made code objects immutable. Glad there's finally a practical use for that.

@larryhastings
Copy link
Contributor Author

I've updated the PR to include the original tarball. The code that generates frozenmodules.c is split across frozen_module.py and _serializer.c. If we move forward with this approach, I think I'd want to rewrite the serializer in pure Python--I don't see the need to split the implementation across C and Python.

@brettcannon brettcannon removed the request for review from a team April 17, 2019 22:46
@brettcannon
Copy link
Member

Removing the import team from reviewing as this is still a WIP. We can be added back when it's ready to go.

@erlend-aasland
Copy link
Contributor

Closed, as this feature has been implemented by the Faster CPython team.

@erlend-aasland erlend-aasland removed the pending The issue will be closed if no feedback is provided label Jul 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants