createConnect, with configurable shallowEqual #182
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Seems like an overkill to add new top-level API when we have |
Contributor
Author
|
Ah yep that'd work too, I thought maybe we were looking to avoid new options :) Will reopen with that. |
Contributor
|
New options are better than new top-level APIs 😉 |
tgriesser
referenced
this pull request
in tgriesser/react-redux
Nov 11, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to
createSelectorCreatorin reselect, providescreateConnectto optionally wrapconnectproviding a custom implementation ofshallowEqual.@ellbee thoughts? Are there any other functions that might be worth allowing customization of?