Handle coercion casts properly when building the MIR

Coercion casts (`expr as T` where the type of `expr` can be coerced to
`T`) are essentially no-ops, as the actual work is done by a coercion.
Previously a check for type equality was used to avoid emitting the
redundant cast in the MIR, but this failed for coercion casts of
function items that had lifetime parameters. The MIR trans code doesn't
handle `FnPtr -> FnPtr` casts and produced an error.

Also fixes a bug with type ascription expressions not having any
adjustments applied.

Fixes #33295

Author: Aatch

src/librustc_mir/build/expr/as_rvalue.rs

@@ -87,12 +87,9 @@ impl<'a,'tcx> Builder<'a,'tcx> {
             }
             ExprKind::Cast { source } => {
                 let source = this.hir.mirror(source);
-                if source.ty == expr.ty {
-                    this.expr_as_rvalue(block, source)
-                } else {
-                    let source = unpack!(block = this.as_operand(block, source));
-                    block.and(Rvalue::Cast(CastKind::Misc, source, expr.ty))
-                }
+
+                let source = unpack!(block = this.as_operand(block, source));
+                block.and(Rvalue::Cast(CastKind::Misc, source, expr.ty))
             }
             ExprKind::ReifyFnPointer { source } => {
                 let source = unpack!(block = this.as_operand(block, source));