Refactor inline assembly handling for GCC

[Zayuz29]

No description provided.

[rustbot]

Some changes occurred in compiler/rustc_codegen_gcc

cc @antoyo, @GuillaumeGomez

[rustbot]

r? @JonathanBrouwer

rustbot has assigned @JonathanBrouwer.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

[rust-log-analyzer]

The job tidy failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

[TIMING:end] tool::Tidy { compiler: Compiler { stage: 0, host: x86_64-unknown-linux-gnu, forced_compiler: false }, target: x86_64-unknown-linux-gnu } -- 0.000
fmt check
Diff in /checkout/compiler/rustc_codegen_gcc/src/asm.rs:117:
 ///
 /// TODO(@Amanieu): Additional mangling is needed on some targets to add
 /// a leading underscore (Mach-O) or byte count suffixes (x86 Windows).
-fn get_symbol_name<'tcx>(tcx: rustc_middle::ty::TyCtxt<'tcx>, instance: Instance<'tcx>) -> &'tcx str {
+fn get_symbol_name<'tcx>(
+    tcx: rustc_middle::ty::TyCtxt<'tcx>,
+    instance: Instance<'tcx>,
+) -> &'tcx str {
     tcx.symbol_name(instance).name
 }
 
Diff in /checkout/compiler/rustc_codegen_gcc/src/asm.rs:522:
                         }
 
                         InlineAsmOperandRef::Label { label } => {
-                            let label_gcc_index =
-                                labels.iter().position(|&l| l == label).expect("label not found in labels");
+                            let label_gcc_index = labels
+                                .iter()
+                                .position(|&l| l == label)
+                                .expect("label not found in labels");
                             let gcc_index = label_gcc_index + outputs.len() + inputs.len();
                             push_to_template(Some('l'), gcc_index);
                         }
Diff in /checkout/compiler/rustc_codegen_gcc/src/asm.rs:672:
 }
 
 /// Converts a register class to its GCC constraint code.
-/// 
+///
 /// Constraint codes can be retrieved from https://gcc.gnu.org/onlinedocs/gcc/Machine-Constraints.html
 fn reg_class_to_gcc(reg_class: InlineAsmRegClass) -> &'static str {
     match reg_class {
Diff in /checkout/compiler/rustc_codegen_gcc/src/asm.rs:729:
             | PowerPCInlineAsmRegClass::lr
             | PowerPCInlineAsmRegClass::xer,
         ) => {
-            unreachable!("cr/ctr/lr/xer are clobber-only and should not appear in constraint generation")
+            unreachable!(
+                "cr/ctr/lr/xer are clobber-only and should not appear in constraint generation"
+            )
         }
         InlineAsmRegClass::RiscV(RiscVInlineAsmRegClass::reg) => "r",
         InlineAsmRegClass::RiscV(RiscVInlineAsmRegClass::freg) => "f",
Diff in /checkout/compiler/rustc_codegen_gcc/src/asm.rs:769:
 }
 
 /// Returns a type suitable for outputs that are discarded.
-/// 
+///
 /// It doesn't really matter what the type is, as long as it is valid for the constraint code.
 fn dummy_output_type<'gcc, 'tcx>(cx: &CodegenCx<'gcc, 'tcx>, reg: InlineAsmRegClass) -> Type<'gcc> {
     match reg {
Diff in /checkout/compiler/rustc_codegen_gcc/src/asm.rs:852:
             unreachable!("areg is clobber-only")
         }
         InlineAsmRegClass::Sparc(SparcInlineAsmRegClass::reg) => cx.type_i32(),
-        InlineAsmRegClass::Sparc(SparcInlineAsmRegClass::yreg) => unreachable!("yreg is clobber-only"),
+        InlineAsmRegClass::Sparc(SparcInlineAsmRegClass::yreg) => {
+            unreachable!("yreg is clobber-only")
+        }
         InlineAsmRegClass::Msp430(Msp430InlineAsmRegClass::reg) => cx.type_i16(),
         InlineAsmRegClass::M68k(M68kInlineAsmRegClass::reg) => cx.type_i32(),
         InlineAsmRegClass::M68k(M68kInlineAsmRegClass::reg_addr) => cx.type_i32(),
Diff in /checkout/compiler/rustc_codegen_gcc/src/asm.rs:942:
 }
 
 /// Converts Rust inline asm register modifiers to GCC modifiers.
-/// 
+///
 /// Modifiers can be retrieved from https://gcc.gnu.org/onlinedocs/gcc/Modifiers.html#Modifiers
 fn modifier_to_gcc(
     arch: InlineAsmArch,
fmt: checked 6587 files
Bootstrap failed while executing `test src/tools/tidy tidyselftest --extra-checks=py,cpp,js,spellcheck`
Build completed unsuccessfully in 0:00:43
  local time: Wed Dec  3 08:16:15 UTC 2025
  network time: Wed, 03 Dec 2025 08:16:15 GMT

[tgross35]

Could you be a bit more detailed in the description about what this is expected to accomplish? Refactoring can accomplish any number of things.

[bjorn3]

Should this be directed at https://github.com/rust-lang/rustc_codegen_gcc/ instead?

[JonathanBrouwer]

Indeed, since this only affects https://github.com/rust-lang/rustc_codegen_gcc, I think it makes sense to do this PR there
@rustbot author

[rustbot]

Reminder, once the PR becomes ready for a review, use @rustbot ready.