On name resolution error in parameter list, suggest possible const typo and avoid unnecessary second error
#149753
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
Collaborator
estebank
commented
Dec 8, 2025
Comment on lines
10
to
19
| error[E0747]: unresolved item provided when a constant was expected | ||
| --> $DIR/const-argument-typo.rs:8:11 | ||
| | | ||
| LL | foo::<CONS>(); | ||
| | ^^^^ | ||
| | | ||
| help: if this generic argument was intended as a const parameter, surround it with braces | ||
| | | ||
| LL | foo::<{ CONS }>(); | ||
| | + + |
Contributor
Author
There was a problem hiding this comment.
This shouldn't be shown. When naively silencing it, an inference error is displayed instead, which is just as bad.
Contributor
Author
There was a problem hiding this comment.
Second commit addresses this.
This comment has been minimized.
This comment has been minimized.
Collaborator
This comment has been minimized.
This comment has been minimized.
estebank
force-pushed
the
issue-149660
branch
from
2745644 to
1ec76fe
Compare
estebank
changed the title
const typoconst typo and avoid unnecessary second error
madsmtm
reviewed
Dec 13, 2025
Contributor
There was a problem hiding this comment.
I'm unfamiliar with how delayed errors and PathSource works, so I'm probably not the right reviewer for determining if this is the correct solution.
The test changes look correct though, so feel free to either reassign, or just r=me if you don't think this is controversial.
Comment on lines
+1038
to
+1043
| if self.diag_metadata.currently_processing_generic_args | ||
| && matches!(source, PathSource::Type) | ||
| { | ||
| source = PathSource::TypeParam; | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
It's not clear to me why we're overriding this only here, and not at a "higher" level (such as in smart_resolve_report_errors)?
madsmtm
added
S-waiting-on-author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #149660.