Detail expectation on non-() block tail in if then condition with no else
#149928
+30
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… no `else` When encountering an `if` expression with no `else` where the then block has a tail expression, we emit an E0308 type error. We now explain why `()` was expected.
rustbot
added
the
S-waiting-on-review
rustbot
added
the
T-compiler
Collaborator
|
r? @fee1-dead rustbot has assigned @fee1-dead. Use |
fee1-dead
reviewed
Dec 12, 2025
| LL | | | ||
| LL | | } | ||
| | |_________- expected this to be `()` | ||
| | |_________- expected this `if` expression to be `()` because it has no `else` arm |
Member
There was a problem hiding this comment.
Aren't we pointing at the block? It seems slightly off to call it an if expression, although I don't have a good alternative in mind right now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When encountering an
ifexpression with noelsewhere the then block has a tail expression, we emit an E0308 type error. We now explain why()was expected.Partially address #144911.