Skip to content

don't use no_main and no_core to test IBT #149969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jyn514 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

don't use no_main and no_core to test IBT #149969

jyn514 wants to merge 1 commit into from
+5 −7

Conversation

@jyn514
Copy link
Member

@jyn514 jyn514 commented Dec 14, 2025 •
edited
Loading

The previous test was quite fragile and depended on a bunch of internal features. Simplify it.

Split out of #149937.

cc @jieyouxu @Oneirical

@rustbot rustbot added A-run-make Area: port run-make Makefiles to rmake.rs S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 14, 2025
@jyn514 jyn514 marked this pull request as ready for review December 14, 2025 01:54
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 14, 2025
@rustbot rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Dec 14, 2025
@rustbot
Copy link
Collaborator

rustbot commented Dec 14, 2025

r? @jieyouxu

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot
Copy link
Collaborator

rustbot commented Dec 14, 2025

⚠️ Warning ⚠️

@jyn514
Copy link
Member Author

jyn514 commented Dec 14, 2025 •
edited
Loading

shhh rustbot i promise i tested it on a newer branch

jieyouxu
jieyouxu approved these changes Dec 14, 2025
View reviewed changes
Copy link
Member

@jieyouxu jieyouxu left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

View changes since this review

@jieyouxu
Copy link
Member

jieyouxu commented Dec 14, 2025

@bors r+

@bors
Copy link
Collaborator

bors commented Dec 14, 2025

📌 Commit 88fca3d has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 14, 2025
cyrgani
cyrgani reviewed Dec 14, 2025
View reviewed changes
tests/run-make/branch-protection-check-IBT/rmake.rs
use run_make_support::{bare_rustc, llvm_readobj};

fn main() {
// `main.rs` is `#![no_std]` to not pull in the currently not-compiled-with-IBT precompiled std.
Copy link
Contributor

@cyrgani cyrgani Dec 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// `main.rs` is `#![no_std]` to not pull in the currently not-compiled-with-IBT precompiled std.
// `lib.rs` is `#![no_std]` to not pull in the currently not-compiled-with-IBT precompiled std.

@jieyouxu
Copy link
Member

jieyouxu commented Dec 14, 2025

Not in a rollup yet, so r=me after fixing the comment.
@bors r-
@bors delegate+

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 14, 2025
@bors
Copy link
Collaborator

bors commented Dec 14, 2025

✌️ @jyn514, you can now approve this pull request!

If @jieyouxu told you to "r=me" after making some further change, please make that change, then do @bors r=@jieyouxu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cyrgani cyrgani cyrgani left review comments

@jieyouxu jieyouxu jieyouxu approved these changes

Assignees

@jieyouxu jieyouxu

Labels

A-run-make Area: port run-make Makefiles to rmake.rs S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jyn514 @rustbot @jieyouxu @bors @cyrgani