Add checks for gpu-kernel calling conv #149991
Open
+981
−152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
rustbot has assigned @WaffleLapkin. Use |
rustbot
added
S-waiting-on-review
This was referenced Dec 14, 2025
Flakebi
force-pushed
the
gpu-kernel-cc
branch
from
b6cb0c2 to
0a9373c
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Flakebi
force-pushed
the
gpu-kernel-cc
branch
from
0a9373c to
1e9b1dc
Compare
This comment has been minimized.
This comment has been minimized.
Flakebi
force-pushed
the
gpu-kernel-cc
branch
from
1e9b1dc to
10b32d6
Compare
This comment has been minimized.
This comment has been minimized.
The `gpu-kernel` calling convention has several restrictions that were not enforced by the compiler until now. Add the following restrictions: 1. Cannot be async 2. Cannot be called 3. Cannot return values, return type must be `()` or `!` 4. Arguments should be simple, i.e. passed by value. More complicated types can work when you know what you are doing, but it is rather unintuitive, one needs to know ABI/compiler internals. 5. Export name should be unmangled, either through `no_mangle` or `export_name`. Kernels are searched by name on the CPU side, having a mangled name makes it hard to find and probably almost always unintentional.
Flakebi
force-pushed
the
gpu-kernel-cc
branch
from
10b32d6 to
88ad16c
Compare
Member
|
r? workingjubilee As I'm completely missing context |
Collaborator
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
gpu-kernelcalling convention has several restrictions that were not enforced by the compiler until now.Add the following restrictions:
()or!no_mangleorexport_name. Kernels are searched by name on the CPU side, having a mangled name makes it hard to find and probably almost always unintentional.Tracking issue: #135467
amdgpu target tracking issue: #135024
@workingjubilee, these should be all the restrictions we talked about a year ago.
cc @RDambrosio016 @kjetilkjeka for nvptx