Skip to content

Conversation

@cuviper
Copy link
Member

@cuviper cuviper commented Jun 30, 2021

Fixes #85863 by removing Fuse's specialization altogether.

@rust-highfive
Copy link
Contributor

r? @kennytm

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 30, 2021
@cuviper
Copy link
Member Author

cuviper commented Jun 30, 2021

Queuing for a performance run, especially relative to #86765.

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jun 30, 2021
@bors
Copy link
Collaborator

bors commented Jun 30, 2021

⌛ Trying commit dc49dd0 with merge 3685c31a52d407c58e576c060e96a12744df78f8...

@bors
Copy link
Collaborator

bors commented Jul 1, 2021

☀️ Try build successful - checks-actions
Build commit: 3685c31a52d407c58e576c060e96a12744df78f8 (3685c31a52d407c58e576c060e96a12744df78f8)

@rust-timer
Copy link
Collaborator

Queued 3685c31a52d407c58e576c060e96a12744df78f8 with parent 868c702, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking try commit (3685c31a52d407c58e576c060e96a12744df78f8): comparison url.

Summary: This change led to significant regressions 😿 in compiler performance.

  • Moderate regression in instruction counts (up to 1.1% on incr-patched: b9b3e592dd cherry picked builds of style-servo-debug)

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf +perf-regression

@rustbot rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Jul 1, 2021
@cuviper
Copy link
Member Author

cuviper commented Jul 7, 2021

Closing in favor of #86765.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

perf-regression Performance regression. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

iter::Fuse is unsound with how specialization currently behaves around HRTB fn pointers

6 participants