Skip to content

Conversation

@martinheidegger
Copy link
Contributor

Webpack (and react-native) doesn't support node globals / global modules. This pull request removes the util global dependency and replaces it with inherits which implements inherits just as node does, but works without globals.

Note: I am sure about the version range of inherits to be used. Used "^2.0.4" for the moment.

@mafintosh
Copy link
Collaborator

This trims down a browserify build as well

@martinheidegger
Copy link
Contributor Author

@rvagg do you need me to do something before this can get merged?

@rvagg
Copy link
Owner

rvagg commented Jun 24, 2020

@martinheidegger no, just time, there's multiple people in this repo that could object and block this so it's appropriate to leave space for any of them to pipe up.

@rvagg
Copy link
Owner

rvagg commented Jun 24, 2020

d30f8f7 & v3.0.2

@rvagg rvagg closed this Jun 24, 2020
@martinheidegger martinheidegger deleted the inherits branch June 24, 2020 02:38
@martinheidegger
Copy link
Contributor Author

@martinheidegger no, just time, there's multiple people in this repo that could object and block this so it's appropriate to leave space for any of them to pipe up.

Got it, thank you for merging it!

so cool

@martinheidegger
Copy link
Contributor Author

Side question: Should I send a similar PR for the 2.x branch?

@rvagg
Copy link
Owner

rvagg commented Jun 24, 2020

@martinheidegger do you use 2.x? probably not, I'd like it to be considered long-dead. See also #103 just now.

@martinheidegger
Copy link
Contributor Author

I don't use 2.x but I have seen dependencies looking like "through2": "2 || 3" which means that the version used by other dependencies may be chosen (other dependency using 2 instead of 3)

@rvagg
Copy link
Owner

rvagg commented Jun 25, 2020

maybe leave it until someone squeaks? if you're packing with the newest webpack that throws up this problem then you're more likely to have v3 in your dependency chain. we can backport if needed but I'm not super keen on keeping ancient things alive and having more surface area for maintenance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants