Groups

golang-codereviews

Contact owners and managers

1–30 of 106787

0 selected

Keith Randall (Gerrit), Cherry Mui (Gerrit)4

11:52 AM

[sys] sys/cpu: add symbolic constants for remaining cpuid bits

Keith Randall submitted the change Change information Commit message: sys/cpu: add symbolic constants

unread,

[sys] sys/cpu: add symbolic constants for remaining cpuid bits

Keith Randall submitted the change Change information Commit message: sys/cpu: add symbolic constants

11:52 AM

Keith Randall (Gerrit), Cherry Mui (Gerrit)4

11:52 AM

[sys] sys/cpu: use symbolic names for masks

Keith Randall submitted the change Change information Commit message: sys/cpu: use symbolic names for

unread,

[sys] sys/cpu: use symbolic names for masks

Keith Randall submitted the change Change information Commit message: sys/cpu: use symbolic names for

11:52 AM

Keith Randall (Gerrit), Cherry Mui (Gerrit)4

11:52 AM

[sys] sys/cpu: modify x86 port to match what internal/cpu does

Keith Randall submitted the change Change information Commit message: sys/cpu: modify x86 port to

unread,

[sys] sys/cpu: modify x86 port to match what internal/cpu does

Keith Randall submitted the change Change information Commit message: sys/cpu: modify x86 port to

11:52 AM

Gerrit Bot (Gerrit), … t hepudds (Gerrit)14

11:43 AM

[go] cmd/cover: exclude commented-out code from coverage instrumentation

Attention needed from Alan Donovan and Than McIntosh t hepudds added 1 comment Patchset-level

unread,

[go] cmd/cover: exclude commented-out code from coverage instrumentation

Attention needed from Alan Donovan and Than McIntosh t hepudds added 1 comment Patchset-level

11:43 AM

Ethan Lee (Gerrit), … kokoro (Gerrit)37

11:42 AM

[pkgsite] internal/frontend: add CodeWiki link support to pkgsite

Attention needed from Ethan Lee and Jonathan Amsterdam kokoro voted kokoro-CI-1 Kokoro presubmit

unread,

[pkgsite] internal/frontend: add CodeWiki link support to pkgsite

Attention needed from Ethan Lee and Jonathan Amsterdam kokoro voted kokoro-CI-1 Kokoro presubmit

11:42 AM

Peter Weinberger (Gerrit), … Alan Donovan (Gerrit)42

11:30 AM

[tools] gopls/mod: find references to required modules

Attention needed from Peter Weinberger Peter Weinberger uploaded new patchset Peter Weinberger

unread,

[tools] gopls/mod: find references to required modules

Attention needed from Peter Weinberger Peter Weinberger uploaded new patchset Peter Weinberger

11:30 AM

Gerrit Bot (Gerrit), … Michael Matloob (Gerrit)8

11:12 AM

[go] cmd/go/internal/tool: include dynamically buildable tools in go tool …

Michael Matloob added 3 comments File src/cmd/go/internal/tool/tool.go Line 152, Patchset 3 (Latest):

unread,

[go] cmd/go/internal/tool: include dynamically buildable tools in go tool …

Michael Matloob added 3 comments File src/cmd/go/internal/tool/tool.go Line 152, Patchset 3 (Latest):

11:12 AM

Lin Lin (Gerrit), … Gopher Robot (Gerrit)8

10:58 AM

[tools] go/analysis/passes/modernize: fix doc URLs in newexpr.go and stringscurt.go

Gopher Robot submitted the change Change information Commit message: go/analysis,gopls: update two

unread,

[tools] go/analysis/passes/modernize: fix doc URLs in newexpr.go and stringscurt.go

Gopher Robot submitted the change Change information Commit message: go/analysis,gopls: update two

10:58 AM

Sean Liao (Gerrit), Michael Matloob (Gerrit)4

10:55 AM

[go] go/doc: link to struct fields in the same package

Attention needed from Alan Donovan and Sean Liao Michael Matloob voted Code-Review+2 Code-Review +2

unread,

[go] go/doc: link to struct fields in the same package

Attention needed from Alan Donovan and Sean Liao Michael Matloob voted Code-Review+2 Code-Review +2

10:55 AM

JB (Gerrit), Gopher Robot (Gerrit)3

10:32 AM

[website] ix/website/tour: default for high bound is length of array

Message from Gopher Robot Congratulations on opening your first change. Thank you for your

unread,

[website] ix/website/tour: default for high bound is length of array

Message from Gopher Robot Congratulations on opening your first change. Thank you for your

10:32 AM

Gopher Robot (Gerrit), … Madeline Kalil (Gerrit)14

10:04 AM

[telemetry] config: regenerate upload config

Attention needed from Alan Donovan, Hongxiang Jiang, Jonathan Amsterdam and Peter Weinberger Madeline

unread,

[telemetry] config: regenerate upload config

Attention needed from Alan Donovan, Hongxiang Jiang, Jonathan Amsterdam and Peter Weinberger Madeline

10:04 AM

Ethan Lee (Gerrit), Hongxiang Jiang (Gerrit)10

4:04 AM

[tools] internal/server: add vulncheck scanning after vulncheck prompt

Attention needed from Ethan Lee Hongxiang Jiang added 7 comments File gopls/internal/server/server.go

unread,

[tools] internal/server: add vulncheck scanning after vulncheck prompt

Attention needed from Ethan Lee Hongxiang Jiang added 7 comments File gopls/internal/server/server.go

4:04 AM

Lin Lin (Gerrit), … Michael Knyszek (Gerrit)4

3:43 AM

[go] cmd: fix unused errors reported by ineffassign

Attention needed from Than McIntosh Lin Lin added 1 comment Patchset-level comments File-level

unread,

[go] cmd: fix unused errors reported by ineffassign

Attention needed from Than McIntosh Lin Lin added 1 comment Patchset-level comments File-level

3:43 AM

Nhan Nguyen (Gerrit)2

Dec 18

[tools] gopls/internal/golang/completion: skip duplicate std/ packages

Attention needed from Nhan Nguyen and Xie Yuchen Nhan Nguyen uploaded new patchset Nhan Nguyen

unread,

[tools] gopls/internal/golang/completion: skip duplicate std/ packages

Attention needed from Nhan Nguyen and Xie Yuchen Nhan Nguyen uploaded new patchset Nhan Nguyen

Dec 18

Hongxiang Jiang (Gerrit), … Gopher Robot (Gerrit)15

Dec 18

[tools] internal/astutil: return enclosing node when Select finds no enclosing node

Gopher Robot submitted the change with unreviewed changes Unreviewed changes 5 is the latest approved

unread,

[tools] internal/astutil: return enclosing node when Select finds no enclosing node

Gopher Robot submitted the change with unreviewed changes Unreviewed changes 5 is the latest approved

Dec 18

Ethan Lee (Gerrit), … Gopher Robot (Gerrit)10

Dec 18

[tools] gopls/internal/server: disable TestCheckGoModDeps for js

Gopher Robot submitted the change Change information Commit message: gopls/internal/server: disable

unread,

[tools] gopls/internal/server: disable TestCheckGoModDeps for js

Gopher Robot submitted the change Change information Commit message: gopls/internal/server: disable

Dec 18

Gerrit Bot (Gerrit), Gopher Robot (Gerrit)2

Dec 18

[tools] gopls: add "Replace := with var declaration" code action

Gopher Robot added 1 comment Patchset-level comments File-level comment, Patchset 1 (Latest): Gopher

unread,

[tools] gopls: add "Replace := with var declaration" code action

Gopher Robot added 1 comment Patchset-level comments File-level comment, Patchset 1 (Latest): Gopher

Dec 18

David Chase (Gerrit), … Cherry Mui (Gerrit)9

Dec 18

[go] internal/cpu: repair VNNI feature check

David Chase submitted the change Change information Commit message: internal/cpu: repair VNNI feature

unread,

[go] internal/cpu: repair VNNI feature check

David Chase submitted the change Change information Commit message: internal/cpu: repair VNNI feature

Dec 18

shuang cui (Gerrit), Keith Randall (Gerrit)6

Dec 18

[go] all: fix some minor grammatical issues in the comments

Attention needed from Joseph Tsai, Keith Randall and Michael Knyszek shuang cui voted and added 1

unread,

[go] all: fix some minor grammatical issues in the comments

Attention needed from Joseph Tsai, Keith Randall and Michael Knyszek shuang cui voted and added 1

Dec 18

Keith Randall (Gerrit), Cuong Manh Le (Gerrit)6

Dec 18

[go] cmd/compile: ensure ops have the expected argument widths

Attention needed from Keith Randall and Michael Pratt Cuong Manh Le voted Code-Review+2 Code-Review +

unread,

[go] cmd/compile: ensure ops have the expected argument widths

Attention needed from Keith Randall and Michael Pratt Cuong Manh Le voted Code-Review+2 Code-Review +

Dec 18

Kirill Kolyshkin (Gerrit), Robert Griesemer (Gerrit)3

Dec 18

[go] runtime: replace sort.Slice with slices.Sort

Attention needed from Dmitry Vyukov, Ian Lance Taylor, Martin Möhrmann and Robert Griesemer Kirill

unread,

[go] runtime: replace sort.Slice with slices.Sort

Attention needed from Dmitry Vyukov, Ian Lance Taylor, Martin Möhrmann and Robert Griesemer Kirill

Dec 18

Kirill Kolyshkin (Gerrit), Robert Griesemer (Gerrit)4

Dec 18

[go] all: replace reflect.TypeOf(x) with TypeFor[T]()

Attention needed from Ian Lance Taylor, Robert Griesemer and Roland Shoemaker Kirill Kolyshkin voted

unread,

[go] all: replace reflect.TypeOf(x) with TypeFor[T]()

Attention needed from Ian Lance Taylor, Robert Griesemer and Roland Shoemaker Kirill Kolyshkin voted

Dec 18

Kirill Kolyshkin (Gerrit), Robert Griesemer (Gerrit)5

Dec 18

[go] all: replace explicit loops over maps with calls to maps package

Attention needed from Austin Clements, Ian Lance Taylor and Robert Griesemer Kirill Kolyshkin voted

unread,

[go] all: replace explicit loops over maps with calls to maps package

Attention needed from Austin Clements, Ian Lance Taylor and Robert Griesemer Kirill Kolyshkin voted

Dec 18

Kirill Kolyshkin (Gerrit), Robert Griesemer (Gerrit)6

Dec 18

[go] all: replace []byte(fmt.Sprintf) with fmt.Appendf

Attention needed from Brad Fitzpatrick, Jonathan Amsterdam and Robert Griesemer Kirill Kolyshkin

unread,

[go] all: replace []byte(fmt.Sprintf) with fmt.Appendf

Attention needed from Brad Fitzpatrick, Jonathan Amsterdam and Robert Griesemer Kirill Kolyshkin

Dec 18

Kirill Kolyshkin (Gerrit), Robert Griesemer (Gerrit)6

Dec 18

[go] all: replace += with strings.Builder

Attention needed from Ian Lance Taylor, Rob Pike and Robert Griesemer Kirill Kolyshkin voted and

unread,

[go] all: replace += with strings.Builder

Attention needed from Ian Lance Taylor, Rob Pike and Robert Griesemer Kirill Kolyshkin voted and

Dec 18

Kirill Kolyshkin (Gerrit), Robert Griesemer (Gerrit)5

Dec 18

[go] all: replace ranging over Split/Fields with SplitSeq/FieldsSeq

Attention needed from Filippo Valsorda, Robert Griesemer and Roland Shoemaker Kirill Kolyshkin voted

unread,

[go] all: replace ranging over Split/Fields with SplitSeq/FieldsSeq

Attention needed from Filippo Valsorda, Robert Griesemer and Roland Shoemaker Kirill Kolyshkin voted

Dec 18

Kirill Kolyshkin (Gerrit)4

Dec 18

[go] all: replace HasPrefix/TrimPrefix with CutPrefix

Attention needed from Brad Fitzpatrick, Ian Lance Taylor and Roland Shoemaker Kirill Kolyshkin voted

unread,

[go] all: replace HasPrefix/TrimPrefix with CutPrefix

Attention needed from Brad Fitzpatrick, Ian Lance Taylor and Roland Shoemaker Kirill Kolyshkin voted

Dec 18

Kirill Kolyshkin (Gerrit), … Robert Griesemer (Gerrit)5

Dec 18

[go] all: replace if/else statements with calls to min or max

Attention needed from Alan Donovan, Austin Clements, Ian Lance Taylor, Michael Pratt, Robert

unread,

[go] all: replace if/else statements with calls to min or max

Attention needed from Alan Donovan, Austin Clements, Ian Lance Taylor, Michael Pratt, Robert

Dec 18

leow kimfui (melalui Google Drive)

Dec 18

Item yang dikongsi dengan anda: "ai-responsibility-update-published-february-2025 (1)_salinan.pdf"

leow kimfui berkongsi satu item leow kimfui ([email protected]) telah berkongsi item berikut: ai-

unread,

Item yang dikongsi dengan anda: "ai-responsibility-update-published-february-2025 (1)_salinan.pdf"

leow kimfui berkongsi satu item leow kimfui ([email protected]) telah berkongsi item berikut: ai-

Dec 18

Marcellus Salvatore

Dec 18

Looking for an awesome blog post? We’ve got it!

Hi, I am Marcellus, A B2B writer committed to composing impactful, SEO-friendly articles for

unread,

Looking for an awesome blog post? We’ve got it!

Hi, I am Marcellus, A B2B writer committed to composing impactful, SEO-friendly articles for

Dec 18

Search

Clear search

Close search

Google apps

Main menu