changeset:   103501:024f3312ccee
parent:      103498:741a87d212da
parent:      103500:16d652760a06
user:        Steve Dower <steve.dower@microsoft.com>
date:        Fri Sep 09 16:39:36 2016 -0700
files:       Misc/NEWS Tools/msi/bundle/bootstrap/PythonBootstrapperApplication.cpp
description:
Issue #25144: Ensures TargetDir is set before continuing with custom install.


diff -r 741a87d212da -r 024f3312ccee Misc/NEWS
--- a/Misc/NEWS	Fri Sep 09 16:15:03 2016 -0700
+++ b/Misc/NEWS	Fri Sep 09 16:39:36 2016 -0700
@@ -333,6 +333,9 @@
 Windows
 -------
 
+- Issue #25144: Ensures TargetDir is set before continuing with custom
+  install.
+
 - Issue #1602: Windows console doesn't input or print Unicode (PEP 528)
 
 - Issue #27781: Change file system encoding on Windows to UTF-8 (PEP 529)
diff -r 741a87d212da -r 024f3312ccee Tools/msi/bundle/bootstrap/PythonBootstrapperApplication.cpp
--- a/Tools/msi/bundle/bootstrap/PythonBootstrapperApplication.cpp	Fri Sep 09 16:15:03 2016 -0700
+++ b/Tools/msi/bundle/bootstrap/PythonBootstrapperApplication.cpp	Fri Sep 09 16:39:36 2016 -0700
@@ -323,6 +323,9 @@
         case ID_CUSTOM_INSTALL_BUTTON:
             SavePageSettings();
 
+            hr = EnsureTargetDir();
+            ExitOnFailure(hr, L"Failed to set TargetDir");
+
             hr = BalGetStringVariable(L"TargetDir", &targetDir);
             if (SUCCEEDED(hr)) {
                 // TODO: Check whether directory exists and contains another installation