changeset:   105885:0a55e039d25f
branch:      3.6
parent:      105883:af8c8551ea45
user:        Benjamin Peterson <benjamin@python.org>
date:        Wed Dec 28 20:02:35 2016 -0800
files:       Misc/NEWS Modules/_randommodule.c
description:
fix error check, so that Random.seed actually uses OS randomness (closes #29085)


diff -r af8c8551ea45 -r 0a55e039d25f Misc/NEWS
--- a/Misc/NEWS	Wed Dec 28 16:02:59 2016 -0800
+++ b/Misc/NEWS	Wed Dec 28 20:02:35 2016 -0800
@@ -40,6 +40,9 @@
 Library
 -------
 
+- Issue #29085: Allow random.Random.seed() to use high quality OS randomness
+  rather than the pid and time.
+
 - Issue #29079: Prevent infinite loop in pathlib.resolve() on Windows
 
 - Issue #13051: Fixed recursion errors in large or resized
diff -r af8c8551ea45 -r 0a55e039d25f Modules/_randommodule.c
--- a/Modules/_randommodule.c	Wed Dec 28 16:02:59 2016 -0800
+++ b/Modules/_randommodule.c	Wed Dec 28 20:02:35 2016 -0800
@@ -245,7 +245,7 @@
         return NULL;
 
      if (arg == NULL || arg == Py_None) {
-        if (random_seed_urandom(self) >= 0) {
+        if (random_seed_urandom(self) < 0) {
             PyErr_Clear();
 
             /* Reading system entropy failed, fall back on the worst entropy: