changeset:   92666:0d115d14adfd
branch:      3.2
user:        Georg Brandl <georg@python.org>
date:        Tue Sep 30 14:56:46 2014 +0200
files:       Lib/test/test_wsgiref.py Lib/wsgiref/simple_server.py Misc/ACKS Misc/NEWS
description:
Issue #22419: Limit the length of incoming HTTP request in wsgiref server to
65536 bytes and send a 414 error code for higher lengths. Patch contributed
by Devin Cook.


diff -r 4fa5239624b8 -r 0d115d14adfd Lib/test/test_wsgiref.py
--- a/Lib/test/test_wsgiref.py	Tue Sep 30 14:54:39 2014 +0200
+++ b/Lib/test/test_wsgiref.py	Tue Sep 30 14:56:46 2014 +0200
@@ -114,6 +114,11 @@
         out, err = run_amock()
         self.check_hello(out)
 
+    def test_request_length(self):
+        out, err = run_amock(data=b"GET " + (b"x" * 65537) + b" HTTP/1.0\n\n")
+        self.assertEqual(out.splitlines()[0],
+                         b"HTTP/1.0 414 Request-URI Too Long")
+
     def test_validated_hello(self):
         out, err = run_amock(validator(hello_app))
         # the middleware doesn't support len(), so content-length isn't there
diff -r 4fa5239624b8 -r 0d115d14adfd Lib/wsgiref/simple_server.py
--- a/Lib/wsgiref/simple_server.py	Tue Sep 30 14:54:39 2014 +0200
+++ b/Lib/wsgiref/simple_server.py	Tue Sep 30 14:56:46 2014 +0200
@@ -114,7 +114,14 @@
     def handle(self):
         """Handle a single HTTP request"""
 
-        self.raw_requestline = self.rfile.readline()
+        self.raw_requestline = self.rfile.readline(65537)
+        if len(self.raw_requestline) > 65536:
+            self.requestline = ''
+            self.request_version = ''
+            self.command = ''
+            self.send_error(414)
+            return
+
         if not self.parse_request(): # An error code has been sent, just exit
             return
 
diff -r 4fa5239624b8 -r 0d115d14adfd Misc/ACKS
--- a/Misc/ACKS	Tue Sep 30 14:54:39 2014 +0200
+++ b/Misc/ACKS	Tue Sep 30 14:56:46 2014 +0200
@@ -219,6 +219,7 @@
 Geremy Condra
 Juan José Conti
 Matt Conway
+Devin Cook
 David M. Cooke
 Jason R. Coombs
 Garrett Cooper
diff -r 4fa5239624b8 -r 0d115d14adfd Misc/NEWS
--- a/Misc/NEWS	Tue Sep 30 14:54:39 2014 +0200
+++ b/Misc/NEWS	Tue Sep 30 14:56:46 2014 +0200
@@ -10,6 +10,10 @@
 Library
 -------
 
+- Issue #22419: Limit the length of incoming HTTP request in wsgiref server to
+  65536 bytes and send a 414 error code for higher lengths. Patch contributed
+  by Devin Cook.
+
 - Issue #22517: When a io.BufferedRWPair object is deallocated, clear its
   weakrefs.