changeset:   104694:1ab1fd00e9d6
parent:      104689:505949cb2692
parent:      104693:6af1a26e655f
user:        Serhiy Storchaka <storchaka@gmail.com>
date:        Tue Oct 25 10:18:16 2016 +0300
files:       Misc/NEWS Objects/unicodeobject.c
description:
Issue #28426: Fixed potential crash in PyUnicode_AsDecodedObject() in debug build.


diff -r 505949cb2692 -r 1ab1fd00e9d6 Misc/NEWS
--- a/Misc/NEWS	Tue Oct 25 09:46:46 2016 +0300
+++ b/Misc/NEWS	Tue Oct 25 10:18:16 2016 +0300
@@ -10,6 +10,9 @@
 Core and Builtins
 -----------------
 
+- Issue #28426: Fixed potential crash in PyUnicode_AsDecodedObject() in debug
+  build.
+
 - Issue #28517: Fixed of-by-one error in the peephole optimizer that caused
   keeping unreachable code.
 
diff -r 505949cb2692 -r 1ab1fd00e9d6 Objects/unicodeobject.c
--- a/Objects/unicodeobject.c	Tue Oct 25 09:46:46 2016 +0300
+++ b/Objects/unicodeobject.c	Tue Oct 25 10:18:16 2016 +0300
@@ -3232,24 +3232,16 @@
                           const char *encoding,
                           const char *errors)
 {
-    PyObject *v;
-
     if (!PyUnicode_Check(unicode)) {
         PyErr_BadArgument();
-        goto onError;
+        return NULL;
     }
 
     if (encoding == NULL)
         encoding = PyUnicode_GetDefaultEncoding();
 
     /* Decode via the codec registry */
-    v = PyCodec_Decode(unicode, encoding, errors);
-    if (v == NULL)
-        goto onError;
-    return unicode_result(v);
-
-  onError:
-    return NULL;
+    return PyCodec_Decode(unicode, encoding, errors);
 }
 
 PyObject *