changeset:   99519:1fe904420c20
parent:      99517:5176e8a2e258
user:        Serhiy Storchaka <storchaka@gmail.com>
date:        Thu Dec 10 09:51:53 2015 +0200
files:       Misc/NEWS Modules/_elementtree.c
description:
Issue #25638: Optimized ElementTree parsing; it is now 10% faster.


diff -r 5176e8a2e258 -r 1fe904420c20 Misc/NEWS
--- a/Misc/NEWS	Wed Dec 09 19:45:07 2015 +0200
+++ b/Misc/NEWS	Thu Dec 10 09:51:53 2015 +0200
@@ -110,6 +110,7 @@
 -------
 
 - Issue #25638: Optimized ElementTree.iterparse(); it is now 2x faster.
+  Optimized ElementTree parsing; it is now 10% faster.
 
 - Issue #25761: Improved detecting errors in broken pickle data.
 
diff -r 5176e8a2e258 -r 1fe904420c20 Modules/_elementtree.c
--- a/Modules/_elementtree.c	Wed Dec 09 19:45:07 2015 +0200
+++ b/Modules/_elementtree.c	Thu Dec 10 09:51:53 2015 +0200
@@ -2491,10 +2491,17 @@
         self->data = NULL;
     }
 
-    if (self->element_factory && self->element_factory != Py_None) {
+    if (!self->element_factory || self->element_factory == Py_None) {
+        node = create_new_element(tag, attrib);
+    } else if (attrib == Py_None) {
+        attrib = PyDict_New();
+        if (!attrib)
+            return NULL;
         node = PyObject_CallFunction(self->element_factory, "OO", tag, attrib);
-    } else {
-        node = create_new_element(tag, attrib);
+        Py_DECREF(attrib);
+    }
+    else {
+        node = PyObject_CallFunction(self->element_factory, "OO", tag, attrib);
     }
     if (!node) {
         return NULL;
@@ -2959,12 +2966,8 @@
             attrib_in += 2;
         }
     } else {
-        /* Pass an empty dictionary on */
-        attrib = PyDict_New();
-        if (!attrib) {
-            Py_DECREF(tag);
-            return;
-        }
+        Py_INCREF(Py_None);
+        attrib = Py_None;
     }
 
     if (TreeBuilder_CheckExact(self->target)) {
@@ -2973,6 +2976,14 @@
                                        tag, attrib);
     }
     else if (self->handle_start) {
+        if (attrib == Py_None) {
+            Py_DECREF(attrib);
+            attrib = PyDict_New();
+            if (!attrib) {
+                Py_DECREF(tag);
+                return;
+            }
+        }
         res = PyObject_CallFunction(self->handle_start, "OO", tag, attrib);
     } else
         res = NULL;