changeset:   102294:3356d7c57750
branch:      3.5
parent:      102280:870e02f86e08
user:        Senthil Kumaran <senthil@uthcode.com>
date:        Sun Jul 10 06:45:38 2016 -0700
files:       Lib/http/cookiejar.py Lib/test/test_http_cookiejar.py Misc/NEWS
description:
Issue #27466: Change time format returned by http.cookie.time2netscape,
confirming the netscape cookie format.


diff -r 870e02f86e08 -r 3356d7c57750 Lib/http/cookiejar.py
--- a/Lib/http/cookiejar.py	Thu Jul 07 17:35:15 2016 +0300
+++ b/Lib/http/cookiejar.py	Sun Jul 10 06:45:38 2016 -0700
@@ -120,7 +120,7 @@
         dt = datetime.datetime.utcnow()
     else:
         dt = datetime.datetime.utcfromtimestamp(t)
-    return "%s %02d-%s-%04d %02d:%02d:%02d GMT" % (
+    return "%s, %02d-%s-%04d %02d:%02d:%02d GMT" % (
         DAYS[dt.weekday()], dt.day, MONTHS[dt.month-1],
         dt.year, dt.hour, dt.minute, dt.second)
 
diff -r 870e02f86e08 -r 3356d7c57750 Lib/test/test_http_cookiejar.py
--- a/Lib/test/test_http_cookiejar.py	Thu Jul 07 17:35:15 2016 +0300
+++ b/Lib/test/test_http_cookiejar.py	Sun Jul 10 06:45:38 2016 -0700
@@ -31,6 +31,28 @@
             self.assertRegex(text, r"^\d{4}-\d\d-\d\d \d\d:\d\d:\d\dZ$",
                              "bad time2isoz format: %s %s" % (az, bz))
 
+    def test_time2netscape(self):
+        base = 1019227000
+        day = 24*3600
+        self.assertEqual(time2netscape(base), "Fri, 19-Apr-2002 14:36:40 GMT")
+        self.assertEqual(time2netscape(base+day),
+                         "Sat, 20-Apr-2002 14:36:40 GMT")
+
+        self.assertEqual(time2netscape(base+2*day),
+                         "Sun, 21-Apr-2002 14:36:40 GMT")
+
+        self.assertEqual(time2netscape(base+3*day),
+                         "Mon, 22-Apr-2002 14:36:40 GMT")
+
+        az = time2netscape()
+        bz = time2netscape(500000)
+        for text in (az, bz):
+            # Format "%s, %02d-%s-%04d %02d:%02d:%02d GMT"
+            self.assertRegex(
+                text,
+                r"[a-zA-Z]{3}, \d{2}-[a-zA-Z]{3}-\d{4} \d{2}:\d{2}:\d{2} GMT$",
+                "bad time2netscape format: %s %s" % (az, bz))
+
     def test_http2time(self):
         def parse_date(text):
             return time.gmtime(http2time(text))[:6]
diff -r 870e02f86e08 -r 3356d7c57750 Misc/NEWS
--- a/Misc/NEWS	Thu Jul 07 17:35:15 2016 +0300
+++ b/Misc/NEWS	Sun Jul 10 06:45:38 2016 -0700
@@ -16,6 +16,10 @@
 Library
 -------
 
+- Issue #27466: Change time format returned by http.cookie.time2netscape,
+  confirming the netscape cookie format and making it consistent with
+  documentation.
+
 - Issue #26664: Fix activate.fish by removing mis-use of ``$``.
 
 - Issue #22115: Fixed tracing Tkinter variables: trace_vdelete() with wrong