changeset:   106254:442eb26b1ca4
branch:      3.5
parent:      106240:bb76ea32a32f
user:        Serhiy Storchaka <storchaka@gmail.com>
date:        Sat Jan 21 23:12:58 2017 +0200
files:       Lib/unittest/mock.py Lib/unittest/test/testmock/testmock.py Misc/NEWS
description:
Issue #28735: Fixed the comparison of mock.MagickMock with mock.ANY.


diff -r bb76ea32a32f -r 442eb26b1ca4 Lib/unittest/mock.py
--- a/Lib/unittest/mock.py	Fri Jan 20 11:29:11 2017 +0800
+++ b/Lib/unittest/mock.py	Sat Jan 21 23:12:58 2017 +0200
@@ -1749,14 +1749,18 @@
         ret_val = self.__eq__._mock_return_value
         if ret_val is not DEFAULT:
             return ret_val
-        return self is other
+        if self is other:
+            return True
+        return NotImplemented
     return __eq__
 
 def _get_ne(self):
     def __ne__(other):
         if self.__ne__._mock_return_value is not DEFAULT:
             return DEFAULT
-        return self is not other
+        if self is other:
+            return False
+        return NotImplemented
     return __ne__
 
 def _get_iter(self):
diff -r bb76ea32a32f -r 442eb26b1ca4 Lib/unittest/test/testmock/testmock.py
--- a/Lib/unittest/test/testmock/testmock.py	Fri Jan 20 11:29:11 2017 +0800
+++ b/Lib/unittest/test/testmock/testmock.py	Sat Jan 21 23:12:58 2017 +0200
@@ -306,13 +306,24 @@
 
 
     def test_calls_equal_with_any(self):
+        # Check that equality and non-equality is consistent even when
+        # comparing with mock.ANY
+        mm = mock.MagicMock()
+        self.assertTrue(mm == mm)
+        self.assertFalse(mm != mm)
+        self.assertFalse(mm == mock.MagicMock())
+        self.assertTrue(mm != mock.MagicMock())
+        self.assertTrue(mm == mock.ANY)
+        self.assertFalse(mm != mock.ANY)
+        self.assertTrue(mock.ANY == mm)
+        self.assertFalse(mock.ANY != mm)
+
         call1 = mock.call(mock.MagicMock())
         call2 = mock.call(mock.ANY)
-
-        # Check that equality and non-equality is consistent even when
-        # comparing with mock.ANY
         self.assertTrue(call1 == call2)
         self.assertFalse(call1 != call2)
+        self.assertTrue(call2 == call1)
+        self.assertFalse(call2 != call1)
 
 
     def test_assert_called_with(self):
diff -r bb76ea32a32f -r 442eb26b1ca4 Misc/NEWS
--- a/Misc/NEWS	Fri Jan 20 11:29:11 2017 +0800
+++ b/Misc/NEWS	Sat Jan 21 23:12:58 2017 +0200
@@ -13,6 +13,8 @@
 Library
 -------
 
+- Issue #28735: Fixed the comparison of mock.MagickMock with mock.ANY.
+
 - Issue #29011:  Fix an important omission by adding Deque to the typing module.
 
 - Issue #29219: Fixed infinite recursion in the repr of uninitialized