changeset:   106477:4e3a16bdadae
branch:      3.6
parent:      106474:80970cf56048
user:        Serhiy Storchaka <storchaka@gmail.com>
date:        Thu Feb 09 20:02:37 2017 +0200
files:       Modules/posixmodule.c
description:
Issue #29513: Fixed a reference leak in os.scandir() added in issue #29034.


diff -r 80970cf56048 -r 4e3a16bdadae Modules/posixmodule.c
--- a/Modules/posixmodule.c	Thu Feb 09 16:08:17 2017 +0100
+++ b/Modules/posixmodule.c	Thu Feb 09 20:02:37 2017 +0200
@@ -11865,7 +11865,6 @@
         }
     }
 
-    Py_CLEAR(iterator->path.object);
     path_cleanup(&iterator->path);
 
     /* Restore the saved exception. */
@@ -11969,12 +11968,6 @@
                                      path_converter, &iterator->path))
         goto error;
 
-    /* path_converter doesn't keep path.object around, so do it
-       manually for the lifetime of the iterator here (the refcount
-       is decremented in ScandirIterator_dealloc)
-    */
-    Py_XINCREF(iterator->path.object);
-
 #ifdef MS_WINDOWS
     iterator->first_time = 1;