changeset:   91127:6b2db7fc17f7
branch:      3.4
parent:      91125:11a920a26f13
user:        Larry Hastings <larry@hastings.org>
date:        Wed Jun 11 04:31:29 2014 -0700
files:       Misc/NEWS Tools/clinic/clinic.py
description:
Issue #21629: Fix Argument Clinic's "--converters" feature.


diff -r 11a920a26f13 -r 6b2db7fc17f7 Misc/NEWS
--- a/Misc/NEWS	Wed Jun 11 08:01:32 2014 +0100
+++ b/Misc/NEWS	Wed Jun 11 04:31:29 2014 -0700
@@ -118,6 +118,11 @@
 - Issue #21671, CVE-2014-0224: The bundled version of OpenSSL has been
   updated to 1.0.1h.
 
+Tools/Demos
+-----------
+
+- Issue #21629: Fix Argument Clinic's "--converters" feature.
+
 
 What's New in Python 3.4.1?
 ===========================
diff -r 11a920a26f13 -r 6b2db7fc17f7 Tools/clinic/clinic.py
--- a/Tools/clinic/clinic.py	Wed Jun 11 08:01:32 2014 +0100
+++ b/Tools/clinic/clinic.py	Wed Jun 11 04:31:29 2014 -0700
@@ -2044,11 +2044,9 @@
     # automatically add converter for default format unit
     # (but without stomping on the existing one if it's already
     # set, in case you subclass)
-    if ((cls.format_unit != 'O&') and
+    if ((cls.format_unit not in ('O&', '')) and
         (cls.format_unit not in legacy_converters)):
         legacy_converters[cls.format_unit] = cls
-        if cls.format_unit:
-            legacy_converters[cls.format_unit] = cls
     return cls
 
 def add_legacy_c_converter(format_unit, **kwargs):