changeset:   96500:6df1b3c6c8e8
branch:      3.5
parent:      96498:c78c5832ccc0
user:        Eric Snow <ericsnowcurrently@gmail.com>
date:        Wed Jun 03 11:09:48 2015 -0600
files:       Misc/NEWS Objects/odictobject.c
description:
Issue #24377: Fix a ref leak in OrderedDict.__repr__.


diff -r c78c5832ccc0 -r 6df1b3c6c8e8 Misc/NEWS
--- a/Misc/NEWS	Wed Jun 03 10:50:37 2015 -0600
+++ b/Misc/NEWS	Wed Jun 03 11:09:48 2015 -0600
@@ -25,6 +25,8 @@
 
 - Issue #24362: Simplify the C OrderedDict fast nodes resize logic.
 
+- Issue #24377: Fix a ref leak in OrderedDict.__repr__.
+
 
 What's New in Python 3.5.0 beta 2?
 ==================================
diff -r c78c5832ccc0 -r 6df1b3c6c8e8 Objects/odictobject.c
--- a/Objects/odictobject.c	Wed Jun 03 10:50:37 2015 -0600
+++ b/Objects/odictobject.c	Wed Jun 03 11:09:48 2015 -0600
@@ -1578,7 +1578,7 @@
             if (value == NULL) {
                 if (!PyErr_Occurred())
                     PyErr_SetObject(PyExc_KeyError, key);
-                return NULL;
+                goto Done;
             }
             pair = PyTuple_Pack(2, key, value);
             if (pair == NULL)