changeset:   101703:74ad78d2dd8d
branch:      3.5
parent:      101699:d83007ab69e2
user:        Serhiy Storchaka <storchaka@gmail.com>
date:        Sat Jun 04 20:32:36 2016 +0300
files:       Lib/test/test_sys_settrace.py Misc/NEWS Objects/frameobject.c
description:
Issue #20041: Fixed TypeError when frame.f_trace is set to None.
Patch by Xavier de Gaye.


diff -r d83007ab69e2 -r 74ad78d2dd8d Lib/test/test_sys_settrace.py
--- a/Lib/test/test_sys_settrace.py	Sat Jun 04 10:20:12 2016 -0700
+++ b/Lib/test/test_sys_settrace.py	Sat Jun 04 20:32:36 2016 +0300
@@ -388,6 +388,15 @@
              (257, 'line'),
              (257, 'return')])
 
+    def test_17_none_f_trace(self):
+        # Issue 20041: fix TypeError when f_trace is set to None.
+        def func():
+            sys._getframe().f_trace = None
+            lineno = 2
+        self.run_and_compare(func,
+            [(0, 'call'),
+             (1, 'line')])
+
 
 class RaisingTraceFuncTestCase(unittest.TestCase):
     def setUp(self):
diff -r d83007ab69e2 -r 74ad78d2dd8d Misc/NEWS
--- a/Misc/NEWS	Sat Jun 04 10:20:12 2016 -0700
+++ b/Misc/NEWS	Sat Jun 04 20:32:36 2016 +0300
@@ -10,6 +10,9 @@
 Core and Builtins
 -----------------
 
+- Issue #20041: Fixed TypeError when frame.f_trace is set to None.
+  Patch by Xavier de Gaye.
+
 - Issue #26168: Fixed possible refleaks in failing Py_BuildValue() with the "N"
   format unit.
 
diff -r d83007ab69e2 -r 74ad78d2dd8d Objects/frameobject.c
--- a/Objects/frameobject.c	Sat Jun 04 10:20:12 2016 -0700
+++ b/Objects/frameobject.c	Sat Jun 04 20:32:36 2016 +0300
@@ -349,15 +349,13 @@
 static int
 frame_settrace(PyFrameObject *f, PyObject* v, void *closure)
 {
-    PyObject* old_value;
-
     /* We rely on f_lineno being accurate when f_trace is set. */
     f->f_lineno = PyFrame_GetLineNumber(f);
 
-    old_value = f->f_trace;
+    if (v == Py_None)
+        v = NULL;
     Py_XINCREF(v);
-    f->f_trace = v;
-    Py_XDECREF(old_value);
+    Py_XSETREF(f->f_trace, v);
 
     return 0;
 }