changeset:   94855:7f64437a707f
branch:      3.4
parent:      94852:77a978716517
user:        Benjamin Peterson <benjamin@python.org>
date:        Wed Mar 04 22:11:12 2015 -0500
files:       Misc/NEWS Modules/_ssl.c
description:
enable X509_V_FLAG_TRUSTED_FIRST when possible (closes #23476)


diff -r 77a978716517 -r 7f64437a707f Misc/NEWS
--- a/Misc/NEWS	Thu Mar 05 02:38:41 2015 +0100
+++ b/Misc/NEWS	Wed Mar 04 22:11:12 2015 -0500
@@ -13,6 +13,9 @@
 Library
 -------
 
+- Issue #23476: In the ssl module, enable OpenSSL's X509_V_FLAG_TRUSTED_FIRST
+  flag on certificate stores when it is available.
+
 - Issue #23576: Avoid stalling in SSL reads when EOF has been reached in the
   SSL layer but the underlying connection hasn't been closed.
 
diff -r 77a978716517 -r 7f64437a707f Modules/_ssl.c
--- a/Modules/_ssl.c	Thu Mar 05 02:38:41 2015 +0100
+++ b/Modules/_ssl.c	Wed Mar 04 22:11:12 2015 -0500
@@ -2063,6 +2063,15 @@
                                    sizeof(SID_CTX));
 #undef SID_CTX
 
+#ifdef X509_V_FLAG_TRUSTED_FIRST
+    {
+        /* Improve trust chain building when cross-signed intermediate
+           certificates are present. See https://bugs.python.org/issue23476. */
+        X509_STORE *store = SSL_CTX_get_cert_store(self->ctx);
+        X509_STORE_set_flags(store, X509_V_FLAG_TRUSTED_FIRST);
+    }
+#endif
+
     return (PyObject *)self;
 }