changeset: 87450:a02adfb3260a parent: 87447:3c222d1f81e9 user: Christian Heimes date: Sat Nov 23 21:13:39 2013 +0100 files: Modules/_pickle.c description: Issue #17810: Add two missing error checks to save_global CID 1131946: Unchecked return value (CHECKED_RETURN) diff -r 3c222d1f81e9 -r a02adfb3260a Modules/_pickle.c --- a/Modules/_pickle.c Sat Nov 23 21:06:21 2013 +0100 +++ b/Modules/_pickle.c Sat Nov 23 21:13:39 2013 +0100 @@ -3193,8 +3193,10 @@ if (self->proto >= 4) { const char stack_global_op = STACK_GLOBAL; - save(self, module_name, 0); - save(self, global_name, 0); + if (save(self, module_name, 0) < 0) + goto error; + if (save(self, global_name, 0) < 0) + goto error; if (_Pickler_Write(self, &stack_global_op, 1) < 0) goto error;