changeset:   95097:a90ec6b96af2
branch:      3.4
parent:      95078:59b8a83ea50b
user:        Serhiy Storchaka <storchaka@gmail.com>
date:        Fri Mar 20 16:11:20 2015 +0200
files:       Lib/tempfile.py
description:
Issue #23700: NamedTemporaryFile iterator closed underlied file object in
some circunstances while NamedTemporaryFile object was living.  This causes
failing test_csv.  Changed the implementation of NamedTemporaryFile.__iter__
to make tests passed.


diff -r 59b8a83ea50b -r a90ec6b96af2 Lib/tempfile.py
--- a/Lib/tempfile.py	Thu Mar 19 16:21:10 2015 -0700
+++ b/Lib/tempfile.py	Fri Mar 20 16:11:20 2015 +0200
@@ -426,9 +426,11 @@
 
     # iter() doesn't use __getattr__ to find the __iter__ method
     def __iter__(self):
-        # don't return iter(self.file), but yield from it to avoid closing
-        # file as long as it's being used as iterator, see issue #23000
-        yield from iter(self.file)
+        # Don't return iter(self.file), but yield from it to avoid closing
+        # file as long as it's being used as iterator, see issue #23000.
+        # XXX Also don't use "yield from"!
+        for line in self.file:
+            yield line
 
 
 def NamedTemporaryFile(mode='w+b', buffering=-1, encoding=None,