changeset:   94305:b0a686260b5d
parent:      94297:c347c21e5afa
parent:      94304:a5769fa55791
user:        Serhiy Storchaka <storchaka@gmail.com>
date:        Mon Jan 26 12:09:59 2015 +0200
files:       Doc/library/timeit.rst Lib/test/test_timeit.py Lib/timeit.py Misc/NEWS
description:
Issue #18518: timeit now rejects statements which can't be compiled outside
a function or a loop (e.g. "return" or "break").


diff -r c347c21e5afa -r b0a686260b5d Doc/library/timeit.rst
--- a/Doc/library/timeit.rst	Mon Jan 26 10:37:44 2015 +0200
+++ b/Doc/library/timeit.rst	Mon Jan 26 12:09:59 2015 +0200
@@ -69,12 +69,6 @@
    .. versionchanged:: 3.5
       The optional *globals* parameter was added.
 
-   .. note::
-
-        Because :meth:`.timeit` is executing *stmt*, placing a return statement
-        in *stmt* will prevent :meth:`.timeit` from returning execution time.
-        It will instead return the data specified by your return statement.
-
 
 .. function:: repeat(stmt='pass', setup='pass', timer=<default timer>, repeat=3, number=1000000, globals=None)
 
diff -r c347c21e5afa -r b0a686260b5d Lib/test/test_timeit.py
--- a/Lib/test/test_timeit.py	Mon Jan 26 10:37:44 2015 +0200
+++ b/Lib/test/test_timeit.py	Mon Jan 26 12:09:59 2015 +0200
@@ -73,9 +73,21 @@
 
     def test_timer_invalid_stmt(self):
         self.assertRaises(ValueError, timeit.Timer, stmt=None)
+        self.assertRaises(SyntaxError, timeit.Timer, stmt='return')
+        self.assertRaises(SyntaxError, timeit.Timer, stmt='yield')
+        self.assertRaises(SyntaxError, timeit.Timer, stmt='yield from ()')
+        self.assertRaises(SyntaxError, timeit.Timer, stmt='break')
+        self.assertRaises(SyntaxError, timeit.Timer, stmt='continue')
+        self.assertRaises(SyntaxError, timeit.Timer, stmt='from timeit import *')
 
     def test_timer_invalid_setup(self):
         self.assertRaises(ValueError, timeit.Timer, setup=None)
+        self.assertRaises(SyntaxError, timeit.Timer, setup='return')
+        self.assertRaises(SyntaxError, timeit.Timer, setup='yield')
+        self.assertRaises(SyntaxError, timeit.Timer, setup='yield from ()')
+        self.assertRaises(SyntaxError, timeit.Timer, setup='break')
+        self.assertRaises(SyntaxError, timeit.Timer, setup='continue')
+        self.assertRaises(SyntaxError, timeit.Timer, setup='from timeit import *')
 
     fake_setup = "import timeit; timeit._fake_timer.setup()"
     fake_stmt = "import timeit; timeit._fake_timer.inc()"
diff -r c347c21e5afa -r b0a686260b5d Lib/timeit.py
--- a/Lib/timeit.py	Mon Jan 26 10:37:44 2015 +0200
+++ b/Lib/timeit.py	Mon Jan 26 12:09:59 2015 +0200
@@ -115,6 +115,12 @@
         local_ns = {}
         global_ns = _globals() if globals is None else globals
         if isinstance(stmt, str):
+            # Check that the code can be compiled outside a function
+            if isinstance(setup, str):
+                compile(setup, dummy_src_name, "exec")
+                compile(setup + '\n' + stmt, dummy_src_name, "exec")
+            else:
+                compile(stmt, dummy_src_name, "exec")
             stmt = reindent(stmt, 8)
             if isinstance(setup, str):
                 setup = reindent(setup, 4)
diff -r c347c21e5afa -r b0a686260b5d Misc/NEWS
--- a/Misc/NEWS	Mon Jan 26 10:37:44 2015 +0200
+++ b/Misc/NEWS	Mon Jan 26 12:09:59 2015 +0200
@@ -218,6 +218,9 @@
 Library
 -------
 
+- Issue #18518: timeit now rejects statements which can't be compiled outside
+  a function or a loop (e.g. "return" or "break").
+
 - Issue #23094: Fixed readline with frames in Python implementation of pickle.
 
 - Issue #23268: Fixed bugs in the comparison of ipaddress classes.