changeset:   89959:b1e3035216f8
parent:      89954:f7a40517f0ac
parent:      89958:7f87c26f59ab
user:        Victor Stinner <victor.stinner@gmail.com>
date:        Tue Mar 25 09:19:14 2014 +0100
files:       Misc/NEWS
description:
(Merge 3.4) Issue #21058: Fix a leak of file descriptor in
tempfile.NamedTemporaryFile(), close the file descriptor if io.open() fails


diff -r f7a40517f0ac -r b1e3035216f8 Lib/tempfile.py
--- a/Lib/tempfile.py	Tue Mar 25 00:43:03 2014 +0100
+++ b/Lib/tempfile.py	Tue Mar 25 09:19:14 2014 +0100
@@ -458,10 +458,14 @@
         flags |= _os.O_TEMPORARY
 
     (fd, name) = _mkstemp_inner(dir, prefix, suffix, flags)
-    file = _io.open(fd, mode, buffering=buffering,
-                    newline=newline, encoding=encoding)
+    try:
+        file = _io.open(fd, mode, buffering=buffering,
+                        newline=newline, encoding=encoding)
 
-    return _TemporaryFileWrapper(file, name, delete)
+        return _TemporaryFileWrapper(file, name, delete)
+    except Exception:
+        _os.close(fd)
+        raise
 
 if _os.name != 'posix' or _os.sys.platform == 'cygwin':
     # On non-POSIX and Cygwin systems, assume that we cannot unlink a file
diff -r f7a40517f0ac -r b1e3035216f8 Lib/test/test_tempfile.py
--- a/Lib/test/test_tempfile.py	Tue Mar 25 00:43:03 2014 +0100
+++ b/Lib/test/test_tempfile.py	Tue Mar 25 09:19:14 2014 +0100
@@ -9,6 +9,7 @@
 import warnings
 import contextlib
 import weakref
+from unittest import mock
 
 import unittest
 from test import support, script_helper
@@ -758,6 +759,17 @@
                 pass
         self.assertRaises(ValueError, use_closed)
 
+    def test_no_leak_fd(self):
+        # Issue #21058: don't leak file descriptor when io.pen() fails
+        closed = []
+        def close(fd):
+            closed.append(fd)
+
+        with mock.patch('os.close', side_effect=close):
+            with mock.patch('io.open', side_effect=ValueError):
+                self.assertRaises(ValueError, tempfile.NamedTemporaryFile)
+                self.assertEqual(len(closed), 1)
+
     # How to test the mode and bufsize parameters?
 
 
@@ -1061,6 +1073,18 @@
             roundtrip("\u039B", "w+", encoding="utf-16")
             roundtrip("foo\r\n", "w+", newline="")
 
+        def test_no_leak_fd(self):
+            # Issue #21058: don't leak file descriptor when io.open() fails
+            closed = []
+            def close(fd):
+                closed.append(fd)
+
+            with mock.patch('os.close', side_effect=close):
+                with mock.patch('io.open', side_effect=ValueError):
+                    self.assertRaises(ValueError, tempfile.TemporaryFile)
+                    self.assertEqual(len(closed), 1)
+
+
 
 # Helper for test_del_on_shutdown
 class NulledModules:
diff -r f7a40517f0ac -r b1e3035216f8 Misc/NEWS
--- a/Misc/NEWS	Tue Mar 25 00:43:03 2014 +0100
+++ b/Misc/NEWS	Tue Mar 25 09:19:14 2014 +0100
@@ -26,6 +26,10 @@
 Library
 -------
 
+- Issue #21058: Fix a leak of file descriptor in
+  :func:`tempfile.NamedTemporaryFile`, close the file descriptor if
+  :func:`io.open` fails
+
 - Issue #21013: Enhance ssl.create_default_context() when used for server side
   sockets to provide better security by default.