changeset:   92454:ba86978c8ab5
branch:      3.4
parent:      92450:d36c0f2ab821
parent:      92453:a4e0aee1a9b5
user:        Senthil Kumaran <senthil@uthcode.com>
date:        Wed Sep 17 16:31:47 2014 +0800
files:       Misc/ACKS Misc/NEWS
description:
Merge from 3.3

Issue #22419: Limit the length of incoming HTTP request in wsgiref server to 65536 bytes.


diff -r d36c0f2ab821 -r ba86978c8ab5 Lib/test/test_wsgiref.py
--- a/Lib/test/test_wsgiref.py	Wed Sep 17 13:19:01 2014 +0800
+++ b/Lib/test/test_wsgiref.py	Wed Sep 17 16:31:47 2014 +0800
@@ -118,6 +118,11 @@
         out, err = run_amock()
         self.check_hello(out)
 
+    def test_request_length(self):
+        out, err = run_amock(data=b"GET " + (b"x" * 65537) + b" HTTP/1.0\n\n")
+        self.assertEqual(out.splitlines()[0],
+                         b"HTTP/1.0 414 Request-URI Too Long")
+
     def test_validated_hello(self):
         out, err = run_amock(validator(hello_app))
         # the middleware doesn't support len(), so content-length isn't there
diff -r d36c0f2ab821 -r ba86978c8ab5 Lib/wsgiref/simple_server.py
--- a/Lib/wsgiref/simple_server.py	Wed Sep 17 13:19:01 2014 +0800
+++ b/Lib/wsgiref/simple_server.py	Wed Sep 17 16:31:47 2014 +0800
@@ -115,7 +115,14 @@
     def handle(self):
         """Handle a single HTTP request"""
 
-        self.raw_requestline = self.rfile.readline()
+        self.raw_requestline = self.rfile.readline(65537)
+        if len(self.raw_requestline) > 65536:
+            self.requestline = ''
+            self.request_version = ''
+            self.command = ''
+            self.send_error(414)
+            return
+
         if not self.parse_request(): # An error code has been sent, just exit
             return
 
diff -r d36c0f2ab821 -r ba86978c8ab5 Misc/ACKS
--- a/Misc/ACKS	Wed Sep 17 13:19:01 2014 +0800
+++ b/Misc/ACKS	Wed Sep 17 16:31:47 2014 +0800
@@ -272,6 +272,7 @@
 Phil Connell
 Juan José Conti
 Matt Conway
+Devin Cook
 David M. Cooke
 Jason R. Coombs
 Garrett Cooper
diff -r d36c0f2ab821 -r ba86978c8ab5 Misc/NEWS
--- a/Misc/NEWS	Wed Sep 17 13:19:01 2014 +0800
+++ b/Misc/NEWS	Wed Sep 17 16:31:47 2014 +0800
@@ -32,6 +32,10 @@
 Library
 -------
 
+- Issue #22419: Limit the length of incoming HTTP request in wsgiref server to
+  65536 bytes and send a 414 error code for higher lengths. Patch contributed
+  by Devin Cook.
+
 - Lax cookie parsing in http.cookies could be a security issue when combined
   with non-standard cookie handling in some Web browsers.  Reported by
   Sergey Bobrov.