changeset: 99142:bddc5491d0fb branch: 3.4 parent: 99135:73da4fd7542b user: Benjamin Peterson date: Sat Nov 14 15:12:18 2015 -0800 files: Misc/NEWS Modules/_ssl.c description: fix possible memory lea k in _get_aia_uri (closes #25578) diff -r 73da4fd7542b -r bddc5491d0fb Misc/NEWS --- a/Misc/NEWS Sat Nov 14 15:10:35 2015 +0200 +++ b/Misc/NEWS Sat Nov 14 15:12:18 2015 -0800 @@ -106,6 +106,8 @@ Library ------- +- Issue #25578: Fix (another) memory leak in SSLSocket.getpeercer(). + - Issue #25590: In the Readline completer, only call getattr() once per attribute. diff -r 73da4fd7542b -r bddc5491d0fb Modules/_ssl.c --- a/Modules/_ssl.c Sat Nov 14 15:10:35 2015 +0200 +++ b/Modules/_ssl.c Sat Nov 14 15:12:18 2015 -0800 @@ -977,7 +977,10 @@ AUTHORITY_INFO_ACCESS *info; info = X509_get_ext_d2i(certificate, NID_info_access, NULL, NULL); - if ((info == NULL) || (sk_ACCESS_DESCRIPTION_num(info) == 0)) { + if (info == NULL) + return Py_None; + if (sk_ACCESS_DESCRIPTION_num(info) == 0) { + AUTHORITY_INFO_ACCESS_free(info); return Py_None; }