changeset:   98814:c3cec0f77eff
parent:      98812:75285bd6991b
parent:      98813:93f948120773
user:        Serhiy Storchaka <storchaka@gmail.com>
date:        Tue Oct 20 18:22:36 2015 +0300
description:
Issue #25410: Fixed a memory leak in OrderedDict in the case when key's hash
calculation fails.


diff -r 75285bd6991b -r c3cec0f77eff Objects/odictobject.c
--- a/Objects/odictobject.c	Tue Oct 20 00:03:33 2015 -0700
+++ b/Objects/odictobject.c	Tue Oct 20 18:22:36 2015 +0300
@@ -648,11 +648,11 @@
     Py_ssize_t i;
     _ODictNode *node;
 
-    Py_INCREF(key);
     hash = PyObject_Hash(key);
     if (hash == -1)
         return -1;
 
+    Py_INCREF(key);
     i = _odict_get_index(od, key);
     if (i < 0) {
         if (!PyErr_Occurred())