changeset:   92645:e834b32f0422
branch:      3.3
parent:      92640:226740b14f1c
user:        Benjamin Peterson <benjamin@python.org>
date:        Mon Sep 29 22:46:57 2014 -0400
files:       Lib/test/test_io.py Misc/NEWS Modules/_io/bufferedio.c
description:
clear BufferedRWPair weakrefs on deallocation (closes #22517)


diff -r 226740b14f1c -r e834b32f0422 Lib/test/test_io.py
--- a/Lib/test/test_io.py	Mon Sep 29 19:12:26 2014 -0400
+++ b/Lib/test/test_io.py	Mon Sep 29 22:46:57 2014 -0400
@@ -1524,6 +1524,12 @@
         pair = self.tp(SelectableIsAtty(True), SelectableIsAtty(True))
         self.assertTrue(pair.isatty())
 
+    def test_weakref_clearing(self):
+        brw = self.tp(self.MockRawIO(), self.MockRawIO())
+        ref = weakref.ref(brw)
+        brw = None
+        ref = None # Shouldn't segfault.
+
 class CBufferedRWPairTest(BufferedRWPairTest):
     tp = io.BufferedRWPair
 
diff -r 226740b14f1c -r e834b32f0422 Misc/NEWS
--- a/Misc/NEWS	Mon Sep 29 19:12:26 2014 -0400
+++ b/Misc/NEWS	Mon Sep 29 22:46:57 2014 -0400
@@ -17,6 +17,9 @@
 Library
 -------
 
+- Issue #22517: When a io.BufferedRWPair object is deallocated, clear its
+  weakrefs.
+
 - Issue #22419: Limit the length of incoming HTTP request in wsgiref server to
   65536 bytes and send a 414 error code for higher lengths. Patch contributed
   by Devin Cook.
diff -r 226740b14f1c -r e834b32f0422 Modules/_io/bufferedio.c
--- a/Modules/_io/bufferedio.c	Mon Sep 29 19:12:26 2014 -0400
+++ b/Modules/_io/bufferedio.c	Mon Sep 29 22:46:57 2014 -0400
@@ -2254,6 +2254,8 @@
 bufferedrwpair_dealloc(rwpair *self)
 {
     _PyObject_GC_UNTRACK(self);
+    if (self->weakreflist != NULL)
+        PyObject_ClearWeakRefs((PyObject *)self);
     Py_CLEAR(self->reader);
     Py_CLEAR(self->writer);
     Py_CLEAR(self->dict);