changeset:   96698:f0053d05ed6d
branch:      3.4
parent:      96689:e189ab8d656a
user:        Serhiy Storchaka <storchaka@gmail.com>
date:        Sun Jun 28 17:06:07 2015 +0300
files:       Lib/contextlib.py Lib/test/test_contextlib.py Lib/test/test_with.py Misc/NEWS
description:
Issue #24336: The contextmanager decorator now works with functions with
keyword arguments called "func" and "self".  Patch by Martin Panter.


diff -r e189ab8d656a -r f0053d05ed6d Lib/contextlib.py
--- a/Lib/contextlib.py	Sat Jun 27 14:26:15 2015 -0500
+++ b/Lib/contextlib.py	Sun Jun 28 17:06:07 2015 +0300
@@ -34,7 +34,7 @@
 class _GeneratorContextManager(ContextDecorator):
     """Helper for @contextmanager decorator."""
 
-    def __init__(self, func, *args, **kwds):
+    def __init__(self, func, args, kwds):
         self.gen = func(*args, **kwds)
         self.func, self.args, self.kwds = func, args, kwds
         # Issue 19330: ensure context manager instances have good docstrings
@@ -52,7 +52,7 @@
         # _GCM instances are one-shot context managers, so the
         # CM must be recreated each time a decorated function is
         # called
-        return self.__class__(self.func, *self.args, **self.kwds)
+        return self.__class__(self.func, self.args, self.kwds)
 
     def __enter__(self):
         try:
@@ -123,7 +123,7 @@
     """
     @wraps(func)
     def helper(*args, **kwds):
-        return _GeneratorContextManager(func, *args, **kwds)
+        return _GeneratorContextManager(func, args, kwds)
     return helper
 
 
diff -r e189ab8d656a -r f0053d05ed6d Lib/test/test_contextlib.py
--- a/Lib/test/test_contextlib.py	Sat Jun 27 14:26:15 2015 -0500
+++ b/Lib/test/test_contextlib.py	Sun Jun 28 17:06:07 2015 +0300
@@ -111,6 +111,14 @@
         baz = self._create_contextmanager_attribs()(None)
         self.assertEqual(baz.__doc__, "Whee!")
 
+    def test_keywords(self):
+        # Ensure no keyword arguments are inhibited
+        @contextmanager
+        def woohoo(self, func, args, kwds):
+            yield (self, func, args, kwds)
+        with woohoo(self=11, func=22, args=33, kwds=44) as target:
+            self.assertEqual(target, (11, 22, 33, 44))
+
 
 class ClosingTestCase(unittest.TestCase):
 
diff -r e189ab8d656a -r f0053d05ed6d Lib/test/test_with.py
--- a/Lib/test/test_with.py	Sat Jun 27 14:26:15 2015 -0500
+++ b/Lib/test/test_with.py	Sun Jun 28 17:06:07 2015 +0300
@@ -12,8 +12,8 @@
 
 
 class MockContextManager(_GeneratorContextManager):
-    def __init__(self, func, *args, **kwds):
-        super().__init__(func, *args, **kwds)
+    def __init__(self, *args):
+        super().__init__(*args)
         self.enter_called = False
         self.exit_called = False
         self.exit_args = None
@@ -31,7 +31,7 @@
 
 def mock_contextmanager(func):
     def helper(*args, **kwds):
-        return MockContextManager(func, *args, **kwds)
+        return MockContextManager(func, args, kwds)
     return helper
 
 
diff -r e189ab8d656a -r f0053d05ed6d Misc/NEWS
--- a/Misc/NEWS	Sat Jun 27 14:26:15 2015 -0500
+++ b/Misc/NEWS	Sun Jun 28 17:06:07 2015 +0300
@@ -60,6 +60,9 @@
 Library
 -------
 
+- Issue #24336: The contextmanager decorator now works with functions with
+  keyword arguments called "func" and "self".  Patch by Martin Panter.
+
 - Issue #24489: ensure a previously set C errno doesn't disturb cmath.polar().
 
 - Issue #5633: Fixed timeit when the statement is a string and the setup is not.