changeset:   105918:f5aa1c9c2b7e
branch:      3.5
parent:      105914:bb64ae455490
user:        Serhiy Storchaka <storchaka@gmail.com>
date:        Sun Jan 01 19:00:30 2017 +0200
files:       Lib/zipfile.py Misc/NEWS
description:
Issue #29094: Offsets in a ZIP file created with extern file object and modes
"w" and "x" now are relative to the start of the file.


diff -r bb64ae455490 -r f5aa1c9c2b7e Lib/zipfile.py
--- a/Lib/zipfile.py	Sat Dec 31 22:48:55 2016 +0300
+++ b/Lib/zipfile.py	Sun Jan 01 19:00:30 2017 +0200
@@ -1028,11 +1028,12 @@
                 # set the modified flag so central directory gets written
                 # even if no files are added to the archive
                 self._didModify = True
+                self._start_disk = 0
                 try:
-                    self.start_dir = self._start_disk = self.fp.tell()
+                    self.start_dir = self.fp.tell()
                 except (AttributeError, OSError):
                     self.fp = _Tellable(self.fp)
-                    self.start_dir = self._start_disk = 0
+                    self.start_dir = 0
                     self._seekable = False
                 else:
                     # Some file-like objects can provide tell() but not seek()
diff -r bb64ae455490 -r f5aa1c9c2b7e Misc/NEWS
--- a/Misc/NEWS	Sat Dec 31 22:48:55 2016 +0300
+++ b/Misc/NEWS	Sun Jan 01 19:00:30 2017 +0200
@@ -140,6 +140,9 @@
 Library
 -------
 
+- Issue #29094: Offsets in a ZIP file created with extern file object and modes
+  "w" and "x" now are relative to the start of the file.
+
 - Issue #13051: Fixed recursion errors in large or resized
   curses.textpad.Textbox.  Based on patch by Tycho Andersen.