Skip to content

Fix typing for IPvAnyAddress and IPvAnyInterface #9990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sydney-runkle merged 2 commits into from
Jul 30, 2024
Merged

Fix typing for IPvAnyAddress and IPvAnyInterface #9990

sydney-runkle merged 2 commits into from
Jul 30, 2024

Conversation

@haoyun
Copy link
Contributor

@haoyun haoyun commented Jul 29, 2024

Change Summary

Following the changes in #9640, make similar changes to IPvAnyAddress and IPvAnyInterface.

Related issue number

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

@github-actions github-actions bot added the relnotes-fix Used for bugfixes. label Jul 29, 2024
@haoyun haoyun mentioned this pull request Jul 29, 2024
Merged
@codspeed-hq
Copy link

codspeed-hq bot commented Jul 29, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #9990 will not alter performance

Comparing haoyun:6522 (b21a283) with main (5ec9845)

Summary

✅ 14 untouched benchmarks

@sydney-runkle sydney-runkle mentioned this pull request Jul 30, 2024
Closed
15 tasks
@sydney-runkle sydney-runkle changed the title fix #6522, following #9640 Fix typing for IPvAnyAddress and IPvAnyInterface Jul 30, 2024
sydney-runkle
sydney-runkle approved these changes Jul 30, 2024
View reviewed changes
Copy link
Contributor

@sydney-runkle sydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@sydney-runkle sydney-runkle enabled auto-merge (squash) July 30, 2024 15:52
@sydney-runkle sydney-runkle merged commit fe08181 into pydantic:main Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@sydney-runkle sydney-runkle sydney-runkle approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

relnotes-fix Used for bugfixes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@haoyun @sydney-runkle