Skip to content

Commit d6dab3d

Browse files
committed
Fix case sensitivity in package name check (resolves #869)
1 parent 35d38a2 commit d6dab3d

File tree

3 files changed

+6
-2
lines changed

3 files changed

+6
-2
lines changed

‎packages/knip/fixtures/dependencies/my-module.ts‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,7 @@
11
import has from 'has';
2+
import JSONStream from 'JSONStream';
3+
4+
JSONStream;
25

36
async function main() {
47
return [require('ansi-regex'), import('ansi-regex')];

‎packages/knip/fixtures/dependencies/package.json‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,8 @@
99
"@sindresorhus/is": "*",
1010
"fs-extra": "*",
1111
"has": "*",
12-
"stream": "*"
12+
"stream": "*",
13+
"JSONStream": "*"
1314
},
1415
"peerDependencies": {
1516
"ansi-regex": "*",

‎packages/knip/src/util/modules.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ export const getPackageNameFromFilePath = (value: string) => {
1919
export const getPackageNameFromSpecifier = (specifier: string) =>
2020
isInNodeModules(specifier) ? getPackageNameFromFilePath(specifier) : getPackageNameFromModuleSpecifier(specifier);
2121

22-
export const isStartsLikePackageName = (specifier: string) => /^(@[a-z0-9._]|[a-z0-9])/.test(specifier);
22+
export const isStartsLikePackageName = (specifier: string) => /^(@[a-z0-9._]|[a-z0-9])/i.test(specifier);
2323

2424
export const stripVersionFromSpecifier = (specifier: string) => specifier.replace(/(\S+)@.*/, '$1');
2525

0 commit comments

Comments
 (0)