Skip to content

Conversation

@deyaaeldeen
Copy link
Contributor

  • I understand that this repository is auto-generated and my pull request may not be merged

Changes being requested

Update Azure code examples to use Entra ID instead of API keys.

Additional context & links

@deyaaeldeen deyaaeldeen requested a review from a team as a code owner May 16, 2024 18:34
@deyaaeldeen deyaaeldeen requested a review from RobertCraigie May 17, 2024 17:36
```ts
const openai = new AzureOpenAI();
import { AzureOpenAI } from 'openai';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm realising now that we don't mention the environment variables the azure client supports, e.g. AZURE_OPENAI_ENDPOINT & AZURE_OPENAI_API_KEY, we should mention these in the README as well. (doesn't block this PR)

Copy link
Collaborator

@RobertCraigie RobertCraigie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

I think CI should run if you target the next branch fyi

@deyaaeldeen deyaaeldeen changed the base branch from master to next May 22, 2024 04:22
@deyaaeldeen
Copy link
Contributor Author

I think CI should run if you target the next branch fyi

Done.

@deyaaeldeen deyaaeldeen requested a review from RobertCraigie May 30, 2024 17:15
@stainless-bot stainless-bot changed the title [Azure] Update example and readme to use Entra ID docs(azure): Update example and readme to use Entra ID May 30, 2024
@stainless-bot stainless-bot changed the title docs(azure): Update example and readme to use Entra ID docs(azure): update example and readme to use Entra ID May 30, 2024
@stainless-bot stainless-bot merged commit 722eff1 into openai:next May 30, 2024
@stainless-app stainless-app bot mentioned this pull request May 30, 2024
@deyaaeldeen deyaaeldeen deleted the azure-sample-entra branch May 30, 2024 23:37
deyaaeldeen added a commit to deyaaeldeen/openai-node that referenced this pull request Aug 10, 2024
SkinnnyJay pushed a commit to SkinnnyJay/openai-node that referenced this pull request Sep 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants