Skip to content

Conversation

@fvsch
Copy link
Contributor

@fvsch fvsch commented Mar 7, 2022

Our types for the VM class are lacking:

  • any for the editor and preview properties
  • Promise<{}> (equivalent to Promise<unknown> in recent TypeScript I believe?) for all methods, including those that actually return a value.
    • In my tests, we return null for all methods on success or when ignored.
    • We return objects of strings or null for getFsSnapshot and getDependencies.

Copy link
Contributor

@ggdaltoso ggdaltoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice update! ✨

@fvsch fvsch force-pushed the fvsch/sdk-improve-vm-types branch from d6e76b2 to 74dbbb8 Compare March 8, 2022 10:09
@fvsch fvsch force-pushed the fvsch/sdk-improve-vm-types branch from 74dbbb8 to 31a765e Compare March 8, 2022 10:36
@fvsch fvsch merged commit af1be8b into main Mar 8, 2022
@fvsch fvsch deleted the fvsch/sdk-improve-vm-types branch March 31, 2022 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants