Fix fediverse post IDs #214
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, this check would return a "user not found" error when retrieving a collection post by its post ID, e.g. /api/posts/abc123 instead of /api/collections/demo/posts/my-slug -- this happens particularly when `Announce`ing a post in the fediverse. This change fixes that.
Previously, fetching ActivityStreams data about a post via /api/posts/ID, instead of /api/collections/ALIAS/posts/SLUG wouldn't include the instance's base URL. This fixes that.
ghost
approved these changes
Nov 27, 2019
ghost
left a comment
ghost
left a comment
There was a problem hiding this comment.
looks good as well, tested both endpoints locally
Member
Author
|
Thanks! Merging now. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, fetching ActivityStreams data about a post via
/api/posts/ID, instead of/api/collections/ALIAS/posts/SLUGwouldn't include the instance's base URL in the post'sid, causing federation issues. This fixes that.It also includes the related fix in #212.