Re: Add SPLIT PARTITION/MERGE PARTITIONS commands

Hi, Jiah He!

Thanks!

1.
>I am confused by the above comments "we compare upper bound only".

Replaced: upper -> lower.

2.
>some of the function partition_rbound_cmp can be replaced by marco
>compare_range_bounds,
>for example in check_two_partitions_bounds_range we can use
>compare_range_bounds instead of partition_rbound_cmp
>not sure if it's worth it or not.

I think would be better keep partition_rbound_cmp in this function
because we should use "false" instead of "second_lower->kind".

3.
><varlistentry id="sql-altertable-split-partition">
>should come after
><varlistentry id="sql-altertable-merge-partitions">
>I’ve refactored the SPLIT PARTITION docs quite a bit—let me know if
>they make sense.
>Also tweaked the regression tests a little again.

Applied.
Unfortunately, I don't know English well enough to spot the inaccuracies
in doc.
It looks good in translation.

--
With best regards,
Dmitry Koval

Postgres Professional: http://postgrespro.com