Re: Add SPLIT PARTITION/MERGE PARTITIONS commands

Hi!
Thank you for the notes and patch!

1.
>ORDER BY regclass seems not stable, see
>https://git.postgresql.org/cgit/postgresql.git/commit/
>?id=17bcf4f5450430f67b744c225566c9e0e6413e95
>some of the SQL tests seem not necessary, so I refactored tests.

Thanks.
Also changed tests for SPLIT PARTITION.

2.
>the last part seems intuitive?
>"colList = lappend(colList, def);" should be at the end of the for loop?

I agree, it's better.

3.
>"-- Not-null constraint name should be 'tp_1_2_i_not_null'.
>Comments conflict with the result.

Thanks, this was correct for older versions.

4.
>* We reject whole-row variables because the whole point of LIKE is
>* that the new table's rowtype might later diverge from the parent's.
...
>the above comment needs change, since LIKE is not related to here.

Corrected.

5.
>here, we don't need expand_generated_columns_in_expr, the comment also
>explained it.
>the attached patch is the changes for the above comments.

Applied.

--
With best regards,
Dmitry Koval

Postgres Professional: http://postgrespro.com