DX: Fix SCA with PHPMD

[paulbalandan]

I found the SCA workflow here using PHPMD very useful and applied it in one of my projects. However, I noted that the actual fixing part with PHPMD is never run. I checked with the actions runs here and it seems the same is true. So after a lot of trial and error fixing the syntax, I found a solution at least working for me and wished to share here.

The problems are:

• The results of git diff with grep is never saved to $GITHUB_ENV, even though there are changed PHP files. This is maybe because of the || true part.
• Check - phpmd step has a condition to run if: ${{ github.env.CHANGED_PHP_FILES }}. The problem here is that the github context does not have the env property. Rather, the env is a context of its own. See https://docs.github.com/en/actions/reference/context-and-expression-syntax-for-github-actions#env-context

[SpacePossum]

thanks for the research 👍
lets see what happens when we run the checks :)

[coveralls]

Coverage remained the same at 92.192% when pulling e18682a on paulbalandan:phpmd-sca into a10bf1c on FriendsOfPHP:3.0.

[paulbalandan]

The 2nd commit shows that phpmd is now being called whenever there are changed PHP files, so the added sample file can now be deleted.

[keradus]

can you re-add the test file again to show how phpmd is kicking off now?

[paulbalandan]

I think the failing CI is unrelated, or not?

[keradus]

i think we are ready to merge @paulbalandan ? if so, pls drop the test file and if CI still green, let's merge

[keradus]

Thank you @paulbalandan.