Skip to content

Support narrowing down via in_array with enum cases #1291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ondrejmirtes merged 1 commit into from
May 9, 2022
Merged

Support narrowing down via in_array with enum cases #1291

ondrejmirtes merged 1 commit into from
May 9, 2022

Conversation

@herndlm
Copy link
Contributor

@herndlm herndlm commented May 5, 2022 •
edited
Loading

Closes phpstan/phpstan#7176

I was wondering if there is a more generic / better way of fixing this. This one at least is the least invasive one I guess.

@herndlm herndlm changed the base branch from 1.7.x to 1.6.x May 5, 2022 17:45
@herndlm herndlm marked this pull request as ready for review May 5, 2022 17:51
staabm
staabm reviewed May 5, 2022
View reviewed changes
@herndlm herndlm force-pushed the fix-7176 branch 4 times, most recently from 3b20724 to 693817a Compare May 5, 2022 19:11
@herndlm
Copy link
Contributor Author

herndlm commented May 5, 2022

I found the other in_array issues now. Looks like there will be one or two more PRs like this and maybe I could look into refactor this then. And, I guess, there was still something with impossible check hacks for in_array which now feels very related. Maybe it's time to look at that then :)

@ondrejmirtes
Copy link
Member

ondrejmirtes commented May 9, 2022

Thank you. in_array needs to be rethought completely, right now it's a buggy mess. It's a hard function to get right.

@ondrejmirtes ondrejmirtes merged commit 790f4fb into phpstan:1.6.x May 9, 2022
@ondrejmirtes ondrejmirtes mentioned this pull request May 9, 2022
Closed
@herndlm herndlm deleted the fix-7176 branch May 9, 2022 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@staabm staabm staabm left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Narrowing possible enum values using in_array() condition

3 participants

@herndlm @ondrejmirtes @staabm