Skip to content

Conversation

@Forceu
Copy link
Contributor

@Forceu Forceu commented Aug 16, 2021

Fixes #6318

According to PHP documentation the function is

socket_select(
    ?array &$read,
    ?array &$write,
    ?array &$except,
    ?int $seconds,
    int $microseconds = 0
): int|false

however Psalm did not allow null for $seconds

@weirdan weirdan merged commit b343ae5 into vimeo:master Aug 17, 2021
@weirdan
Copy link
Collaborator

weirdan commented Aug 17, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

False positive when passing null to socket_select

2 participants