Make UnitEnum name property non-empty

[ricardoboss]

No description provided.

[orklah]

Thanks, that's great!

[ricardoboss]

Hi @orklah, it seems I made a mistake somewhere: https://psalm.dev/r/1bf1de16e0

Any idea why this PR didn't fix this?

[psalm-github-bot]

I found these snippets:

https://psalm.dev/r/1bf1de16e0

<?php

interface A {
    /**
     * @return non-empty-string
     */
    public function getName(): string;
}

enum B implements A {
    case Test;
    
    public function getName(): string
    {
        return $this->name;
    }
}

Psalm output (using commit 39402c2):

ERROR: ParseError - 10:6 - Syntax error, unexpected T_STRING on line 10

ERROR: ParseError - 17:1 - Syntax error, unexpected '}', expecting EOF on line 17

[orklah]

Yeah, sorry, I should have thought about that, there's special code for handling ->name on enums here:

psalm/src/Psalm/Internal/Analyzer/Statements/Expression/Fetch/AtomicPropertyFetchAnalyzer.php

Line 205 in 39402c2

$statements_analyzer->node_data->setType($stmt, Type::getString());

I wonder if we could drop the whole block now that we have a stub... Do you mind trying that? If it doesn't work, then we need to replace Type::getString by a Type::getNonEmptyString()

[ricardoboss]

I'll look into it!

[ricardoboss]

So I tried flat-out removing the else branch, which led to an error in the tests saying "unable to infer return type". I then proceeded to change the line you mentioned to set the type to Type::getNonEmptyString() and that worked. Do you want to try to remove the special handling or is this fine as it is?

[orklah]

that's fine, thanks for your help!