don't stop analyzing array, even if we already have a type and we can't create an object like #7093
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…'t create an object like
Collaborator
Author
|
Well, that broke a test but in a goodish way. the string part was ignored before so that's a fix. The weird thing is that We set the "allow_mixed_union" param to true in TypeCombiner. It does what it says and it allows mixed in unions. So, I fixed the test that way. |
orklah
added
the
release:fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal is to fix #7090
But seeing the change I had to do, it'll probably break something elsewhere, Let's run the CI!