Skip to content

Conversation

@hirokinoue
Copy link
Contributor

Fixes #6798

This PR, which targets 4.x instead of master, includes the same commits as #7871.

@hirokinoue
Copy link
Contributor Author

@AndrolGenhald-san
I may have misunderstood your comment. I thought that you have mentioned about a new issue related to ArithmeticOpAnalyzer. Sorry for my poor English.
Did you mean that we should restructure the code in this PR? If so I need time or even I'm not sure if I can currently. So I'll closed this PR if I should.

@orklah orklah added the release:fix The PR will be included in 'Fixes' section of the release notes label Apr 19, 2022
@orklah
Copy link
Collaborator

orklah commented Apr 19, 2022

Sorry for the delay :)

I'm perfectly happy with this, any further improvement can be made later, don't worry!

Thanks!

@orklah orklah merged commit 2724c1d into vimeo:4.x Apr 19, 2022
@hirokinoue hirokinoue deleted the float-template-arithmetics-4.x branch April 20, 2022 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release:fix The PR will be included in 'Fixes' section of the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MixedOperand with conditional type

2 participants