This repository was archived by the owner on Sep 24, 2018. It is now read-only.
Power the Comments endpoint args from the schema, like everything else #1422
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous args had defaults of empty strings for `wp_allow_comment`, however I see this as an incorrect use of the abstraction. Args should not have defaults just to please an underlaying function that expects those values. This also needed to move into `create_item` as the same default can not be used for the `update_item` endpoint args.
Member
|
Intended to fix #1418 |
Member
rachelbaker
added a commit
that referenced
this pull request
Jul 25, 2015
Power the Comments endpoint args from the schema, like everything else
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous args had defaults of empty strings for
wp_allow_comment,however I see this as an incorrect use of the abstraction. Args should not
have defaults just to please an underlaying function that expects those
values.
This also needed to move into
create_itemas the same default can not beused for the
update_itemendpoint args.