Fix: Clang 19 -Wc++20-extensions warning #2910 #2934
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-Added INTERNAL_CATCH_TEMPLATE_TEST_CASE_HANDLE_EMPTY macro for Clang 19+ - Modified template test case macro expansion path for Clang 19+ - Keeps original behavior for other compilers and older Clang versions
…chorg#2910) - Added INTERNAL_CATCH_TEMPLATE_TEST_CASE_HANDLE_EMPTY macro for Clang 19+ - Modified template test case macro expansion path for Clang 19+ - Keeps original behavior for other compilers and older Clang versions
Collaborator
|
Could you please remove all the unrelated whitespace changes you made? |
|
Just hit this... Can I submit a fix for the whitespace request? |
Collaborator
If you’d like to make a new PR which includes the relevant changes from this PR minus all the unrelated formatting/whitespace changes, I’d appreciate that. |
|
Collaborator
|
Superseded by #2968 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue where Clang 19 reports a
-Wc++20-extensionswarning when expanding theTEMPLATE_TEST_CASEmacro family. The warning occurs because passing no arguments to the...parameter of a variadic macro was technically a language extension before C++20, and Clang 19 enforces this more strictly.The fix introduces a special handling path for Clang 19+ that modifies how template test case macros are expanded, while maintaining the existing behavior for other compilers and older Clang versions. This allows the code to compile without warnings on Clang 19 while preserving full functionality and backward compatibility.
Key changes:
INTERNAL_CATCH_TEMPLATE_TEST_CASE_HANDLE_EMPTYmacro for Clang 19+ specific handlingCloses #2910