Skip to content

Conversation

@diaowinner
Copy link
Contributor

Add Simplified Chinese Localization of Hackers' Pub.


BTW is there any compatible issues like what I did in PinkSea?

Copy link
Member

@dahlia dahlia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! I left some review comments.

@dahlia
Copy link
Member

dahlia commented Mar 17, 2025

In recent commits, editor.contentPlaceholder was changed. Could you apply the change to the Chinese translation too?

@dahlia
Copy link
Member

dahlia commented Mar 17, 2025

Also, article.replied was added.

@diaowinner
Copy link
Contributor Author

diaowinner commented Mar 17, 2025 via email

@dahlia
Copy link
Member

dahlia commented Mar 17, 2025

Okay, no hurry!

@diaowinner
Copy link
Contributor Author

OK, the hyphen was removed (I know the problem when contributing the PinkSea project before) and new texts were added.

Copy link
Member

@dahlia dahlia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good. Thanks!

@dahlia dahlia merged commit 56f96c5 into hackers-pub:main Mar 18, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants