This repository was archived by the owner on Jul 31, 2025. It is now read-only.
remove literal copy of sync.Mutex from memory store #793
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
Signed-off-by: George Tankersley <[email protected]>
gtank
force-pushed
the
memstore-lock-copy
branch
from
a295cd8 to
0d69ee3
Compare
Contributor
|
jenkins, test this please |
Contributor
|
Thanks lots for fixing these vetting issues @gtank! Should make it easier to upgrade to 1.7 when it's released. :) LGTM! I have no problems with this - these are mainly used for testing, and I don't foresee needing multiple |
Contributor
|
thank you @gtank, LGTM! |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempted fix of #792. The locks seem to be covered already by the KeyMemoryStore, which is the only place that uses MemoryFileStore.
I think the go vet issue at hand is golang/go#13675 (comment)